Optimize input reading and output writing #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit aims to fix issue #20. Use the Emscripten FS.writeFile API for accepting XML input files, instead of the createDataFile and especially the intArrayFromString function. Those were inherited from the parent upstream project, but this writeFile API seems to be simpler to use and performs better. The bigger fix, though, is in the output side, as pushing one piece of stdout (I guess it was pushing one byte at a time?) caused the stdoutBuffer array to eventually grow so large that it'd throw > RangeError [Error]: Invalid array length when the output was very big, like when normalizing a big input XML, as described in #20. Here, too, we can switch to the print/printErr APIs, which seem to be not only simpler but also more resilient to the input size growing.
noppa
force-pushed
the
issue-20-invalid-array-length-fix
branch
from
a639621
to
b835d5b
Compare
Since we will anyway make a potentially breaking change and a major version bump, I think this is a good time to raise the minimum officially supported Node.js a bit. Also, TypeScript tests were failing after upgrading TS version, because TypeScript no longer supports Node.js < 14.17, and I have no interest in bending over backwards to make that combination work.
The memory consumption has probably gotten better in PR #21, and the test was always super flakey anyway, and often passes even without increasing the memory limit. Just drop that "should error with out of memory" test altogether. At least the test still has those initialMemoryPages options, so those code paths get some coverage, even though there's no actual counterexample to make sure they are improving things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to fix issue #20.
Use the Emscripten FS.writeFile API for accepting XML input files, instead of the createDataFile and especially the intArrayFromString function. Those were inherited from the parent upstream project, but this writeFile API seems to be simpler to use and performs better.
The bigger fix, though, is in the output side, as pushing one piece of stdout (I guess it was pushing one byte at a time?) caused the stdoutBuffer array to eventually grow so large that it'd throw
when the output was very big, like when normalizing a big input XML, as described in #20.
Here, too, we can switch to the print/printErr APIs, which seem to be not only simpler but also more resilient to the input size growing.