Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the community map, allow lists of places for groups (and individuals) #455

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

rantahar
Copy link
Member

@rantahar rantahar commented Jun 4, 2024

No description provided.

@rantahar rantahar requested a review from samumantha June 4, 2024 09:14
Copy link

github-actions bot commented Jun 4, 2024

Once the build has completed, you can preview your PR at this URL: https://nordic-rse.github.io/previews/PR455/

@rantahar
Copy link
Member Author

rantahar commented Jun 4, 2024

This draws each institute in all places listed (and same for individuals, if they list multiple places). The downside is that it adds multiple pins where no individual RSE is marked close by.

@rantahar
Copy link
Member Author

rantahar commented Jun 4, 2024

The preview does not seem to work. I think it still loads the javascript from the main version.

@rantahar rantahar requested a review from bast June 4, 2024 09:31
@lucaferranti
Copy link
Member

You need to tweak manually the link of the preview when you look at something which is not the homepage, see this issue: #453.

Correct link should be: https://nordic-rse.org/previews/PR455/communities/map/

@rantahar
Copy link
Member Author

rantahar commented Jun 4, 2024

@lucaferranti, that still loads the wrong javascript.

@rantahar
Copy link
Member Author

rantahar commented Jun 4, 2024

Made a quick fix in the map data by using only one location. This is easy to revert

@lucaferranti
Copy link
Member

yeah, I noticed that. Not sure why 🤔

@lucaferranti
Copy link
Member

I think if you ran that locally and works locally, we can assume it's just github setup and merge this

@rantahar
Copy link
Member Author

rantahar commented Jun 4, 2024

It works, but I'm not sure we want to do this. It's more a suggested fix.

@rantahar rantahar merged commit 5c88d41 into main Jun 4, 2024
2 checks passed
@bast bast deleted the map_multiple_locations branch June 4, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants