add isort to manage/sort imports #864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemith
force-pushed
the
nemith/isort
branch
from
7356c61
to
8a4c37b
Compare
|
This is fine by me, I am all for delegating as many opinions as possible to intransigent machines so if Kirk is fine with this too we can merge after the conflicts has been resolved. |
dbarrosop
approved these changes
Sep 22, 2023
nemith
force-pushed
the
nemith/isort
branch
from
8a4c37b
to
dd8793a
Compare
|
Sounds good to me. |
nemith
force-pushed
the
nemith/isort
branch
from
dd8793a
to
21da3b7
Compare
ktbyers
reviewed
Sep 22, 2023
| @@ -1,5 +1,7 @@ | |||
| from typing import List, Protocol | |||
|
|
|||
| from typing_extensions import Protocol | |||
There was a problem hiding this comment.
@nemith It looks like you need to rebase to get the latest changes that I released last night.
|
Replaced by: It was easier to just redo the PR than to fix the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
isortas a way to cleanup and manage imports in addition toblack.Black is great tool and will format the import lines, but doesn't sort them, remove unused imports, or sorts them but it does work well with the
isort(import sort) tool.https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#isort
Black was developed by Łukasz which at facebook and there we always used black along side isort as well.
See https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#isort