remove mypy_extensions dep #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemith
force-pushed
the
nemith/remove_mypy_ext
branch
from
c8fb7fb
to
1f69e49
Compare
nemith
force-pushed
the
nemith/remove_mypy_ext
branch
from
1f69e49
to
d352923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #861 I noticed that the way the Callable and with the arguments from
mypy_extensionis deprecated and no longer needed. This is supported natively in typing in 3.8 or greater with theProtocoltype.So this moves to using
Protocolwith a__call__stub instead of themypy_extensions.Fixes: #868