Add NIP-19 bech32 identifier generation for note, nevent, and naddr prefixes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmontz
requested changes
Jun 30, 2024
Co-authored-by: Bryan Montz <[email protected]>
…EventCoordinates function in the ReplaceableEvent protocol for easier readability
…r ReplaceableEvents
bryanmontz
approved these changes
Jul 1, 2024
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
…refixes (nostr-sdk#166) * Add NIP-19 bech32 identifier generation for note, nevent, and naddr prefixes * Apply suggestions from code review Co-authored-by: Bryan Montz <[email protected]> * Fix incomplete sentence in the Bech32IdentifierType documentation * Remove unused bech32NoteIdPrefix constant * Inverse the excludeAuthor and excludeKind parameters in the shareableEventCoordinates function in the ReplaceableEvent protocol for easier readability * Refactor duplicate code for the shareableEventCoordinates function for ReplaceableEvents --------- Co-authored-by: Bryan Montz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nostr-protocol/nips/blob/master/19.md
This change enables clients to generate shareable identifiers easily for human consumption.
I also refactored the
npubandnsecbech32 prefixes into theBech32IdentifierTypeenum.