Refactor out common non-NIP-01 tags out of NostrEvent file into separ… #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate protocols for better code separation
tyiu
force-pushed
the
tyiu/refactor-non-nip-01-tags
branch
from
5a25155
to
c76c110
Compare
tyiu
commented
Nov 3, 2024
| @@ -10,7 +10,7 @@ import Foundation | |||
| /// A structure that describes a Nostr event. | |||
| /// | |||
| /// > Note: [NIP-01 Specification](https://github.com/nostr-protocol/nips/blob/master/01.md#events-and-signatures) | |||
| public class NostrEvent: Codable, Equatable, Hashable, ContentWarningTagInterpreting, LabelTagInterpreting { | |||
| public class NostrEvent: Codable, Equatable, Hashable, AlternativeSummaryTagInterpreting, ContentWarningTagInterpreting, ExpirationTagInterpreting, LabelTagInterpreting { | |||
There was a problem hiding this comment.
Making this change allows us to keep the base NostrEvent class clean for only the NIP-01 implementation. Any other NIPs that apply to all event kinds can be introduced as a separate protocol/extension that NostrEvent extends from. It'll let us maintain the code much easier.
| @@ -318,7 +291,7 @@ public protocol NostrEventBuilding { | |||
|
|
|||
| public extension NostrEvent { | |||
| /// Builder of a ``NostrEvent`` of type `T`. | |||
| class Builder<T: NostrEvent>: NostrEventBuilding, ContentWarningTagBuilding, LabelBuilding { | |||
| class Builder<T: NostrEvent>: NostrEventBuilding, AlternativeSummaryTagBuilding, ContentWarningTagBuilding, ExpirationTagBuilding, LabelTagBuilding { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ate protocols for better code separation