This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
refactor(snoowrap.js): Convert to TypeScript #214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markspolakovs I don't suppose you would want to help me out with this one? Converting snoowrap.js to a TS component 😅 |
|
I can take a look at it later today @SpyTec 👍 |
|
I fixed pretty most of the issues, though quite a few remain. There's also quite a bit of |
|
@SpyTec I've fixed a couple more type errors in my branch (https://github.com/markspolakovs/snoowrap/tree/refactor/ts/snoowrap), I'll work through the rest as time permits |
|
Awesome, thank you for the help :) |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP and should only be merged once tests + manual inspection has been done
This changes the main snoowrap.js to TypeScript so that other objects can be more easily converted.