Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl display trait for New and Unseal #24

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Impl display trait for New and Unseal #24

merged 1 commit into from
Sep 12, 2023

Conversation

brh28
Copy link
Collaborator

@brh28 brh28 commented Sep 12, 2023

Description

Implements display traits for NewResponse and UnsealResponse which is used for the command line rather than Debug

Notes to the reviewers

Does not include error handling.

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Impl display trait for New and Unseal
77c04a3 
Address clippy warning to use writeln
notmandatory
notmandatory approved these changes Sep 12, 2023
View reviewed changes
Copy link
Owner

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 77c04a3

@notmandatory notmandatory merged commit 77c04a3 into notmandatory:master Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brh28 @notmandatory