chore(framework, api): Remove deprecated X- prefixed headers (#6783)

novuhq · Oct 28, 2024 · c8c51d0 · c8c51d0
1 parent bd2f04d
commit c8c51d0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/apps/api/src/app/bridge/bridge.controller.ts b/apps/api/src/app/bridge/bridge.controller.ts
@@ -14,6 +14,7 @@ import {
   UseInterceptors,
 } from '@nestjs/common';
 
+import { HttpHeaderKeysEnum } from '@novu/framework/internal';
 import { ControlValuesLevelEnum, UserSessionData, WorkflowOriginEnum, WorkflowTypeEnum } from '@novu/shared';
 import { AnalyticsService, ExternalApiAccessible, UserAuthGuard, UserSession } from '@novu/application-generic';
 import { ControlValuesRepository, EnvironmentRepository, NotificationTemplateRepository } from '@novu/dal';
@@ -84,14 +85,12 @@ export class BridgeController {
   @ExternalApiAccessible()
   @UseGuards(UserAuthGuard)
   async createBridgesByDiscovery(
-    @Headers('x-novu-anonymous') anonymousIdDeprecated: string,
-    @Headers('novu-anonymous') anonymousId: string,
+    @Headers(HttpHeaderKeysEnum.NOVU_ANONYMOUS) anonymousId: string,
     @UserSession() user: UserSessionData,
     @Body() body: CreateBridgeRequestDto,
     @Query('source') source?: string
   ): Promise<CreateBridgeResponseDto> {
-    const chosenAnonymousIdHeader = anonymousId ?? anonymousIdDeprecated;
-    if (chosenAnonymousIdHeader && chosenAnonymousIdHeader !== 'null') {
+    if (anonymousId) {
       this.analyticsService.alias(anonymousId, user._id);
     }
 
@@ -111,7 +110,7 @@ export class BridgeController {
   @ExternalApiAccessible()
   @UseGuards(UserAuthGuard)
   async createDiscoverySoft(
-    @Headers('x-novu-anonymous') anonymousId: string,
+    @Headers(HttpHeaderKeysEnum.NOVU_ANONYMOUS) anonymousId: string,
     @UserSession() user: UserSessionData,
     @Body() body: CreateBridgeRequestDto
   ): Promise<CreateBridgeResponseDto> {
@@ -121,7 +120,7 @@ export class BridgeController {
       throw new BadRequestException('Bridge URL not found');
     }
 
-    if (anonymousId && anonymousId !== 'null') {
+    if (anonymousId) {
       this.analyticsService.alias(anonymousId, user._id);
     }
 

diff --git a/...application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts b/...application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts
@@ -173,7 +173,6 @@ export class ExecuteBridgeRequest {
     return {
       [HttpRequestHeaderKeysEnum.BYPASS_TUNNEL_REMINDER]: 'true',
       [HttpRequestHeaderKeysEnum.CONTENT_TYPE]: 'application/json',
-      [HttpHeaderKeysEnum.NOVU_SIGNATURE_DEPRECATED]: novuSignatureHeader,
       [HttpHeaderKeysEnum.NOVU_SIGNATURE]: novuSignatureHeader,
     };
   }

diff --git a/packages/framework/src/constants/http-headers.constants.ts b/packages/framework/src/constants/http-headers.constants.ts
@@ -1,8 +1,6 @@
 export enum HttpHeaderKeysEnum {
   NOVU_SIGNATURE = 'novu-signature',
   NOVU_ANONYMOUS = 'novu-anonymous',
-  NOVU_SIGNATURE_DEPRECATED = 'x-novu-signature',
-  NOVU_ANONYMOUS_DEPRECATED = 'x-novu-anonymous',
   NOVU_FRAMEWORK_SDK = 'novu-framework-sdk',
   NOVU_FRAMEWORK_SERVER = 'novu-framework-server',
   NOVU_FRAMEWORK_VERSION = 'novu-framework-version',

diff --git a/packages/framework/src/handler.ts b/packages/framework/src/handler.ts
@@ -135,10 +135,7 @@ export class NovuRequestHandler<Input extends any[] = any[], Output = any> {
     const action = url.searchParams.get(HttpQueryKeysEnum.ACTION) || GetActionEnum.HEALTH_CHECK;
     const workflowId = url.searchParams.get(HttpQueryKeysEnum.WORKFLOW_ID) || '';
     const stepId = url.searchParams.get(HttpQueryKeysEnum.STEP_ID) || '';
-    const signatureHeader =
-      (await actions.headers(HttpHeaderKeysEnum.NOVU_SIGNATURE)) ||
-      (await actions.headers(HttpHeaderKeysEnum.NOVU_SIGNATURE_DEPRECATED)) ||
-      '';
+    const signatureHeader = (await actions.headers(HttpHeaderKeysEnum.NOVU_SIGNATURE)) || '';
 
     let body: Record<string, unknown> = {};
     try {