Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(root): add IS_WORKFLOW_PREFERENCES_ENABLED variable #6757

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

jainpawan21
Copy link
Member

@jainpawan21 jainpawan21 commented Oct 23, 2024

What changed? Why was the change needed?

  • Add IS_WORKFLOW_PREFERENCES_ENABLED variable in worker image to resolve the feature flag error. That error will be fixed by this PR

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@SokratisVidros
Copy link
Contributor

SokratisVidros commented Oct 23, 2024

@jainpawan21 This PR will be obsolete as soon as we merge this. The plan is to merge it by the end of this week.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit b4d7fd7
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6718e27eb7013000081f4786
😎 Deploy Preview https://deploy-preview-6757--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jainpawan21
Copy link
Member Author

@jainpawan21 This PR will be obsolete as soon as we merge this. The plan is to merge it by the end of this week.

@SokratisVidros

After that PR merge, this issue will still be there until we release new docker images. This is a temporary urgent fix for community self host users

@SokratisVidros
Copy link
Contributor

@jainpawan21 This PR will be obsolete as soon as we merge this. The plan is to merge it by the end of this week.

@SokratisVidros

After that PR merge, this issue will remain until we release new docker images. This is a temporary urgent fix for community self-host users

We will do an OS release immediately after we merge the feature flag PR.

@jainpawan21
Copy link
Member Author

jainpawan21 commented Oct 23, 2024

Waiting for the above PR merge and new docker images release 🙂 . Lets keep this PR opened, so that I can refer users to this PR.

@SokratisVidros
Copy link
Contributor

I am closing this PR as this change is now merged. We will do a new Community Release, next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants