-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): persist payload variables #6833
Open
djabarovgeorge
wants to merge
5
commits into
next
Choose a base branch
from
nv-4569-persist-payload-variables-in-workflowstep-entity
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(api): persist payload variables #6833
djabarovgeorge
wants to merge
5
commits into
next
from
nv-4569-persist-payload-variables-in-workflowstep-entity
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
November 3, 2024 15:29
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 3, 2024 15:29
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 3, 2024 15:29
— with
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
temporarily deployed
to
Linting
November 3, 2024 15:54
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 3, 2024 15:54
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 3, 2024 15:54
— with
GitHub Actions
Inactive
djabarovgeorge
commented
Nov 3, 2024
@@ -375,3 +400,19 @@ function isWorkflowUpdateDto( | |||
const isUniqueStepId = (stepIdToValidate: string, otherStepsIds: string[]) => { | |||
return !otherStepsIds.some((stepId) => stepId === stepIdToValidate); | |||
}; | |||
|
|||
function extractPlaceholders(text: string): string[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self note: reuse already existing function in the preview use case.
@novu/client
@novu/framework
@novu/js
@novu/headless
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
djabarovgeorge
changed the title
feat(api): wip persist payload variables
feat(api): persist payload variables
Nov 4, 2024
…ad-variables-in-workflowstep-entity # Conflicts: # apps/api/src/app/workflows-v2/usecases/upsert-workflow/upsert-workflow.usecase.ts # libs/dal/src/repositories/notification-template/notification-template.entity.ts
djabarovgeorge
temporarily deployed
to
Linting
November 4, 2024 17:15
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 4, 2024 17:15
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 4, 2024 17:15
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 4, 2024 19:16
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 4, 2024 19:16
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 4, 2024 19:16
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer