Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): persist payload variables #6833

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Nov 3, 2024

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 7c9e9b7
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67291d8fa3b6560008e14a58
😎 Deploy Preview https://deploy-preview-6833--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -375,3 +400,19 @@ function isWorkflowUpdateDto(
const isUniqueStepId = (stepIdToValidate: string, otherStepsIds: string[]) => {
return !otherStepsIds.some((stepId) => stepId === stepIdToValidate);
};

function extractPlaceholders(text: string): string[] {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self note: reuse already existing function in the preview use case.

Copy link

pkg-pr-new bot commented Nov 3, 2024

Open in Stackblitz

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6833

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6833

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6833

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6833

@novu/nextjs

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@6833

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6833

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6833

novu

pnpm add https://pkg.pr.new/novuhq/novu@6833

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6833

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6833

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6833

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6833

commit: 7c9e9b7

@djabarovgeorge djabarovgeorge changed the title feat(api): wip persist payload variables feat(api): persist payload variables Nov 4, 2024
@djabarovgeorge djabarovgeorge marked this pull request as ready for review November 4, 2024 16:56
…ad-variables-in-workflowstep-entity

# Conflicts:
#	apps/api/src/app/workflows-v2/usecases/upsert-workflow/upsert-workflow.usecase.ts
#	libs/dal/src/repositories/notification-template/notification-template.entity.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant