feat: Add APIContext object to Auth Config #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to the Auth Config file where users can define a function which accept the Astro global object (for Astro pages/components) or the APIContext object (for API Routes). This allows Cloudflare D1 users to use the environment provided by the cloudflare bindings, rather the the vite environment variables. Adds getSessionByContext(), which allows fetching the session when using a lazy auth config. Fixes nowaythatworked#60, nowaythatworked#52, nowaythatworked#50.
Comment on lines
+95
to
+109
| const config = isUserConfigLazy(options) ? await options.config(context) : options | ||
| config.secret ??= AUTH_SECRET | ||
| config.trustHost ??= !!(AUTH_TRUST_HOST ?? VERCEL ?? NODE_ENV !== 'production') | ||
|
|
||
| const { prefix = '/api/auth', ...authOptions } = config | ||
| const handler = AstroAuthHandler(prefix, authOptions) | ||
| return await handler(context) | ||
| }, | ||
| async POST(context: APIContext) { | ||
| const config = isUserConfigLazy(options) ? await options.config(context) : options | ||
| config.secret ??= AUTH_SECRET | ||
| config.trustHost ??= !!(AUTH_TRUST_HOST ?? VERCEL ?? NODE_ENV !== 'production') | ||
|
|
||
| const { prefix = '/api/auth', ...authOptions } = config | ||
| const handler = AstroAuthHandler(prefix, authOptions) |
There was a problem hiding this comment.
would be nice to have this a bit cleaner, not so repetitive.
Comment on lines
+121
to
+125
| if (isUserConfigLazy(options)) { | ||
| throw new Error( | ||
| 'User Auth Configuration is Lazy. Fetch the session using getSessionByContext().' | ||
| ) | ||
| } |
There was a problem hiding this comment.
Since you're already checking for lazy config, we could have the functionality of getSessionByContext directly in here, right?
The req argument would need to be replaced with context (AstroGlobal, etc) which would be a breaking change, but I think that would be fine? Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to the Auth Config file where users can define a function which accepts the Astro global object (for Astro pages/components) or the APIContext object (for API Routes).
This allows Cloudflare D1 users to use the environment provided by the cloudflare bindings, rather the the vite environment variables.
Adds getSessionByContext(), which allow fetching the session when using a lazy auth config.
Fixes #60, #52, #50.