Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich code navigation specific pipeline #1540

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jepetty
Copy link

@jepetty jepetty commented Oct 19, 2020

I've added a Rich Navigation specific build (which will appear as a new GitHub workflow), indexing on every push. This will allow you to use Rich Navigation in Visual Studio to enable cross-repository searches, serverless navigation at https://online.visualstudio.com/github/dotnet/msbuild, and integrated GitHub C# navigation once that is released. It also indexes your pull requests for a richer code review experience.

Rich Code Navigation

Docs Link
With Rich Code Navigation, you can use editor-level navigation capabilities (like peek definition, find all references, and even diagnostics) on a pull request, without requiring a local checkout. This is available across all files and dependencies of your repository.

Rich Code Navigation is available for Visual Studio (for repos hosted on GitHub or Azure Repos) and Visual Studio Code (for repos hosted on GitHub).

Rich Code Navigation supports these capabilities:

  • Hover
  • Peek definition and Go to definition
  • Peek references and Find all references
  • Go to type definition
  • Go to implementation
  • Diagnostics

@jepetty
Copy link
Author

jepetty commented Oct 19, 2020

@roji FYI from our chat earlier :)

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jepetty! Some comments below, I can fix this up too if you don't have the time.

on: [push, pull_request]

env:
postgis_version: 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's probably not needed

- name: Setup .NET Core SDK
uses: actions/setup-dotnet@v1
with:
dotnet-version: ${{ env.dotnet_sdk_version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is based on our build.yml, but the env var doesn't exist here... Do we actually need .NET Core SDK and dotnet build below?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants