Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP on improving compatibility of efcore.pg with CockroachDB #2892

Draft
wants to merge 77 commits into
base: main
Choose a base branch
from
Draft

WIP on improving compatibility of efcore.pg with CockroachDB #2892

wants to merge 77 commits into from

Commits on Oct 5, 2023

  1. Add CI workflow for building Cockroach

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    cec4f45 View commit details
    Browse the repository at this point in the history

  2. Update to use version 8.0.0-preview-5-ci of Npgsql packages

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5c4fbad View commit details
    Browse the repository at this point in the history

  3. Run tests with blame-hang-timeout

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    949315a View commit details
    Browse the repository at this point in the history

  4. Run tests with quiet verbosity

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    f1c478c View commit details
    Browse the repository at this point in the history

  5. Exclude tables from crdb_internal and pg_extension 

    Update to exclude tables from crdb_internal and pg_extension which exist for CockroachDB
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c0134ab View commit details
    Browse the repository at this point in the history

  6. For CockroachDB, suppress transaction for DropForeignKeyOperation

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    786e676 View commit details
    Browse the repository at this point in the history

  7. When dropping user funcs, exclude from crdb_internal and pg_extension

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c905195 View commit details
    Browse the repository at this point in the history

  8. For CockroachDB, do not call unsupported func pg_indexam_has_property

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b32cc9b View commit details
    Browse the repository at this point in the history

  9. Change verbosity level for running tests

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    cd1f5c9 View commit details
    Browse the repository at this point in the history

  10. Execute transaction in SERIALIZABLE isolation level for CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7055e7e View commit details
    Browse the repository at this point in the history

  11. Update build-cockroach workflow to run test againtst v23.1

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    502d410 View commit details
    Browse the repository at this point in the history

  12. Use a different Northwind database script for CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e0f82ec View commit details
    Browse the repository at this point in the history

  13. Skip tests that hang for CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9bff187 View commit details
    Browse the repository at this point in the history

  14. Update build-cockroach to upload blame log file

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ed1ceaa View commit details
    Browse the repository at this point in the history

  15. Fix build-cockroach.yml

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8e62388 View commit details
    Browse the repository at this point in the history

  16. Update build-cockroach.yml

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    60af85d View commit details
    Browse the repository at this point in the history

  17. Update build-cockroach.yml

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    dacc06f View commit details
    Browse the repository at this point in the history

  18. Increase test blame timeout

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    0e387eb View commit details
    Browse the repository at this point in the history

  19. Update build-cockroach.yml

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    aa3b62c View commit details
    Browse the repository at this point in the history

  20. Skip NodaTimeQueryNpgsqlTest for CockroachDB 

    Skip NodaTimeQueryNpgsqlTest for CockroachDB due to the lack of support for range types
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    acf54e3 View commit details
    Browse the repository at this point in the history

  21. Add xunit configuration longRunningTestSeconds

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    548dff2 View commit details
    Browse the repository at this point in the history

  22. Add xunit configuration diagnosticMessages

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    946a96c View commit details
    Browse the repository at this point in the history

  23. Update BatchingTest to not use Version field as concurrency token column

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2d9c753 View commit details
    Browse the repository at this point in the history

  24. Set xunit configuration maxParallelThreads to 1

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    75a2c86 View commit details
    Browse the repository at this point in the history

  25. Increase blame-hang-timeout

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    027676b View commit details
    Browse the repository at this point in the history

  26. Update build-cockroach.yml. Disable test parallelization

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7a77563 View commit details
    Browse the repository at this point in the history

  27. Fix build-cockroach.yml

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1aa4334 View commit details
    Browse the repository at this point in the history

  28. Skip CitextQueryTest, RangeQueryNpgsqlTest, LTreeQueryTest, NetworkQu… 

    …eryNpgsqlTest
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    717e985 View commit details
    Browse the repository at this point in the history

  29. Add UseCockroachDb to NpgsqlDbContextOptions

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4bd9769 View commit details
    Browse the repository at this point in the history

  30. Avoid using unsupported xmin column and JSON column type for CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b072087 View commit details
    Browse the repository at this point in the history

  31. Workaround to reset identity for truncated table for CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    84f1043 View commit details
    Browse the repository at this point in the history

  32. Remove use of unsupported function pg_terminate_backend for CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e4c289f View commit details
    Browse the repository at this point in the history

  33. Update NpgsqlTestStore to target CockroachDB for better compatibility

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1b1002c View commit details
    Browse the repository at this point in the history

  34. Skip tests in FullTextSearchDbFunctionsNpgsqlTest for CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6b1a554 View commit details
    Browse the repository at this point in the history

  35. Skip tests in PrimitiveCollectionsQueryNpgsqlTest 

    Skip tests in PrimitiveCollectionsQueryNpgsqlTest that tests unsupported features
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ae47be8 View commit details
    Browse the repository at this point in the history

  36. Skip tests in NorthwindSplitIncludeNoTrackingQueryNpgsqlTest 

    Related Github issue: dotnet/efcore#26808
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ffeae1f View commit details
    Browse the repository at this point in the history

  37. Skip tests in SqlExecutorNpgsqlTest that tests unsupported features 

    Github issue: cockroachdb/cockroach#100226
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    737541a View commit details
    Browse the repository at this point in the history

  38. Skip tests in UdfDbFunctionNpgsqlTests that tests unsupported features

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6948ba3 View commit details
    Browse the repository at this point in the history

  39. Update MigrationsInfrastructureNpgsqlTest to target CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c8fa04c View commit details
    Browse the repository at this point in the history

  40. Skip tests in Array tests that test unsupported features 

    Github issue: cockroachdb/cockroach#109953
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b8246b6 View commit details
    Browse the repository at this point in the history

  41. Skip tests in FuzzyStringMatchQueryNpgsqlTest

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5244c3b View commit details
    Browse the repository at this point in the history

  42. Update SequenceEndToEndTest to add compatibility with CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a7317f1 View commit details
    Browse the repository at this point in the history

  43. Fix code for reseting sequence value in StoreValueGenerationNpgsqlTest

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    22f315f View commit details
    Browse the repository at this point in the history

  44. Update test in JsonStringQueryTest to match with CockroachDB behavior

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    936b09e View commit details
    Browse the repository at this point in the history

  45. Skip GearsOfWarQuery tests that use infinity which is not well supported

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    942c9ac View commit details
    Browse the repository at this point in the history

  46. Fix error in ArrayArrayQueryTest

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c342de1 View commit details
    Browse the repository at this point in the history

  47. Skip incompatible test in NonSharedPrimitiveCollectionsQueryNpgsqlTest

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5b6fb60 View commit details
    Browse the repository at this point in the history

  48. Update test in NpgsqlMigrationsSqlGeneratorTest to be compatible

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e5c99e1 View commit details
    Browse the repository at this point in the history

  49. Update test in JsonDomQueryTest to be compatible

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b8ce164 View commit details
    Browse the repository at this point in the history

  50. Update tests in BuiltInDataTypesNpgsqlTest to ignore unsupported types

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7eadb6e View commit details
    Browse the repository at this point in the history

  51. Make IsCockroachDb virtual

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    dd1a33b View commit details
    Browse the repository at this point in the history

  52. Skip OptimisticConcurrency tests due to incompatibility

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    37ad6d3 View commit details
    Browse the repository at this point in the history

  53. Update BuiltInDataTypesNpgsqlTest to be compatible with CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c78847c View commit details
    Browse the repository at this point in the history

  54. Skip tests in GearOfWearQuery that fail due to incompatibility

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9b3d9c4 View commit details
    Browse the repository at this point in the history

  55. Skip test in CharacterQueryNpgsqlTest due to different behavior

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7ce59d6 View commit details
    Browse the repository at this point in the history

  56. Skip test in CompatibilityQueryNpgsqlTest that tests Redshift

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ca4d4ee View commit details
    Browse the repository at this point in the history

  57. Skip tests in TrigramsQueryNpgsqlTest that test unsupported features

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a582596 View commit details
    Browse the repository at this point in the history

  58. Skip test in SystemColumnTest that tests unsupported xmin column

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a56b8fd View commit details
    Browse the repository at this point in the history

  59. Update NpgsqlDatabaseCreatorTest to target CockroachDB for compatibility

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    cf9d616 View commit details
    Browse the repository at this point in the history

  60. Update DefaultValuesTest to target CockroachDB for compatibility

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b514595 View commit details
    Browse the repository at this point in the history

  61. Skip NorthwindDbFunctionsQuery tests that test unsupported features

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    36e2084 View commit details
    Browse the repository at this point in the history

  62. Skip NorthwindFunctionsQuery tests that test unsupported features

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a7709ee View commit details
    Browse the repository at this point in the history

  63. Skip tests in NorthwindAggregateOperatorsQuery due to known issues

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    850df9a View commit details
    Browse the repository at this point in the history

  64. Skip Northwind tests that fail due to known issues

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d083534 View commit details
    Browse the repository at this point in the history

  65. Update and skip tests in TimestampQueryTest 

    Skip tests that fail due to known issues and unsupported features
Update tests to be compatible with CockroachDB behavior
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9f91c29 View commit details
    Browse the repository at this point in the history

  66. Update NpgsqlMigrationSqlGenerator to be compatible with CockroachDB 

    - Suppress transaction for operations that change schema
- Use CREATE SCHEMA IF NOT EXISTS because CockroachDB doesn't support IF
- Cast computed value to target column type as CockroachDB doesn't do it automatically
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1d6c7df View commit details
    Browse the repository at this point in the history

  67. Update NpgsqlDatabaseCleaner to be compatible with CockroachDB 

    - Drop user-defined types at last because CockroachDB doesn't support DROP TYPE CASCADE
- Use DROP FUNCTION because CockroachDB doesn't support DROP ROUTINE
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    279343a View commit details
    Browse the repository at this point in the history

  68. Update NpgsqlDatabaseModelFactory to be compatible with CockroachDB 

    - Remove hidden column generated by CockroachDB when primary key is not defined
- Other CockroachDB differences
- Skip tests in NpgsqlDatabaseModelFactoryTest that are not compatible
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a7e9c1d View commit details
    Browse the repository at this point in the history

  69. Update tests in NpgsqlDatabaseModelFactoryTest to be compatible

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e8a0280 View commit details
    Browse the repository at this point in the history

  70. Workaround in NpgsqlDatabaseCreator to resolve Cockroach incompatibility 

    Workaround for CockroachDB issue that doesn't return error when database name is invalid cockroachdb/cockroach#109992
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d721073 View commit details
    Browse the repository at this point in the history

  71. Skip tests in MigrationsNpgsqlTest that test unsupported features

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7f46530 View commit details
    Browse the repository at this point in the history

  72. Update tests in MigrationsNpgsqlTest to be compatible with CockroachDB

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    15c1c99 View commit details
    Browse the repository at this point in the history

  73. Update build-cockroach.yml

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    283bbf7 View commit details
    Browse the repository at this point in the history

  74. Fix merge issues

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    942e97d View commit details
    Browse the repository at this point in the history

  75. Fix PrimitiveCollectionsQueryNpgsqlTest 

    - Add missing tests
- Skip tests that use unsupported features
    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2bf27a9 View commit details
    Browse the repository at this point in the history

  76. Skip test with incompatibility in FullTextSearchDbFunctionsNpgsqlTest

    @giangpham712
    giangpham712 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ef41515 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Skip incompatible tests in MigrationsNpgsqlTest

    @giangpham712
    giangpham712 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2ed60c4 View commit details
    Browse the repository at this point in the history