tests: net: lib: nrf_cloud: add fota_common tests #11734

jayteemo · 2023-07-06T21:26:39Z

Add test suite for nrf_cloud_fota_common.c.
IRIS-4790

NordicBuilder · 2023-07-17T23:23:27Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
dragoon	f870a908c06de77fd4913370e97a92684782cf76	8088a53e2c71384a8cb3dfc51ce37f68a8c4088b	N/A
find-my	https://github.com/nrfconnect/sdk-find-my/commit/68e82297568d9c8e1d244e87858b4bd332643605	https://github.com/nrfconnect/sdk-find-my/commit/c30e0186e6476e439ffdbf83ebb421662031cbd1 (main)	nrfconnect/[email protected]
hostap	nrfconnect/sdk-hostap@`8e2e758`	nrfconnect/sdk-hostap@`42a92ba` (main)	nrfconnect/[email protected]
matter	nrfconnect/sdk-connectedhomeip@`6d0b631`	nrfconnect/sdk-connectedhomeip@`7f724e8` (master)	nrfconnect/[email protected]
mcuboot	nrfconnect/sdk-mcuboot@`4e84f31` (upmerge-tmp)	nrfconnect/sdk-mcuboot@`823fd36` (main)	nrfconnect/[email protected]
nrf-802154	https://github.com/nrfconnect/sdk-nrf-802154/commit/43a0e760e7e47589739da632f852237d6331dacf	https://github.com/nrfconnect/sdk-nrf-802154/commit/109821b9e3a9b1d3536e2ab86b6d174e2af64743	nrfconnect/[email protected]
nrfxlib	nrfconnect/sdk-nrfxlib@`4eca399`	nrfconnect/sdk-nrfxlib@`16721d9` (main)	nrfconnect/[email protected]
openthread	nrfconnect/sdk-openthread@`11a38a6`	nrfconnect/sdk-openthread@`5beae14` (main)	nrfconnect/[email protected]
trusted-firmware-m	nrfconnect/sdk-trusted-firmware-m@`ccab64f`	nrfconnect/sdk-trusted-firmware-m@`c5b393b`	nrfconnect/[email protected]
zephyr	nrfconnect/sdk-zephyr@`01e2e4c`	nrfconnect/sdk-zephyr@`b37ce40` (upmerge-tmp)	nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2023-07-21T19:00:13Z

Test specification

CI/Jenkins/NRF

Integration Platforms

CI/Jenkins/integration

Test Module	File based changes	Manually selected	West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

glarsennordic

Stopping review here since I suspect with some added comments reviewing will go faster

tests/subsys/net/lib/nrf_cloud/fota_common/src/main.c

glarsennordic · 2023-07-27T17:20:33Z

tests/subsys/net/lib/nrf_cloud/fota_common/testcase.yaml

+      - CONFIG_MCUBOOT_IMG_MANAGER=y
+      - CONFIG_BOOTLOADER_MCUBOOT=y
+      - CONFIG_IMG_MANAGER=y
+      - CONFIG_STREAM_FLASH_ERASE=y
+      - CONFIG_NRF_CLOUD_FOTA_FULL_MODEM_UPDATE=y


Suggested change

- CONFIG_MCUBOOT_IMG_MANAGER=y

- CONFIG_BOOTLOADER_MCUBOOT=y

- CONFIG_IMG_MANAGER=y

- CONFIG_STREAM_FLASH_ERASE=y

- CONFIG_NRF_CLOUD_FOTA_FULL_MODEM_UPDATE=y

- CONFIG_MCUBOOT_IMG_MANAGER=y

- CONFIG_BOOTLOADER_MCUBOOT=y

- CONFIG_IMG_MANAGER=y

- CONFIG_STREAM_FLASH_ERASE=y

- CONFIG_NRF_CLOUD_FOTA=y

- CONFIG_NRF_CLOUD_REST=y

- CONFIG_FOTA_DOWNLOAD=y

- CONFIG_NRF_CLOUD_FOTA_FULL_MODEM_UPDATE=y

CONFIG_NRF_CLOUD_REST=y is not needed.

CONFIG_NRF_CLOUD_MQTT=y in the prj.conf results in the selection of CONFIG_NRF_CLOUD_FOTA and CONFIG_FOTA_DOWNLOAD, I will add comments.

tests/subsys/net/lib/nrf_cloud/fota_common/testcase.yaml

glarsennordic · 2023-07-27T17:54:40Z

tests/subsys/net/lib/nrf_cloud/fota_common/src/main.c

+{
+	Z_TEST_SKIP_IFNDEF(CONFIG_NRF_CLOUD_FOTA_FULL_MODEM_UPDATE);
+
+#if defined(CONFIG_NRF_CLOUD_FOTA_FULL_MODEM_UPDATE)


Given how abundant these fmfu tests are, it seems worthwhile for them to have their own test folder so that you can avoid giving them all ZTEST_SKIP statements and conditionally defined bodies.

So, like, essentially an entire copy of the fota_common test folder, but named fota_fmfu and containing only the tests and fakes required for FMFU

If I understand correctly there would be very few, if any, duplicated fakes between fota_common and fota_fmfu

i moved them into their own file.

glarsennordic · 2023-07-27T19:07:52Z

tests/subsys/net/lib/nrf_cloud/fota_common/src/main.c

+/* Verify that nrf_cloud_pending_fota_job_process succeeds when a pending
+ * FMFU FOTA validation PASSES.
+ * The reboot flag should become true.
+ * Must be called after nrf_cloud_fota_fmfu_dev_set() is successful.


Can you point out which part of the test guarantees this? I'm guessing it is part of how you have the fakes configured, but it would be useful to have a comment in the test explaining why setting the fakes this way causes nrf_cloud_fota_fmfu_dev_set to succeed

It would also be good to document what entity internally calls nrf_cloud_fota_fmfu_dev_set in this case

By default the tests are sorted and ran in alphanumerical order. Test cases may be dependent on this sequence. - ztest
the name of the test guarantees this.

what entity internally calls nrf_cloud_fota_fmfu_dev_set in this case

the test test_07_nrf_cloud_fota_fmfu_dev_set_pass results in a successful call to nrf_cloud_fota_fmfu_dev_set

tests/subsys/net/lib/nrf_cloud/fota_common/src/main.c

tests/subsys/net/lib/nrf_cloud/fota_common/src/fmfu.c

tests/subsys/net/lib/nrf_cloud/fota_common/src/main.c

tony-le-24

LGTM!

Add test suite for nrf_cloud_fota_common.c. IRIS-4790 Signed-off-by: Justin Morton <[email protected]>

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 6, 2023

jayteemo force-pushed the IRIS-4790 branch from e1d4734 to fc8b9c6 Compare July 6, 2023 22:48

jayteemo requested a review from tony-le-24 July 6, 2023 22:50

NordicBuilder added manifest-nrf-802154 manifest-dragoon manifest-hostap manifest-mcuboot manifest-zephyr manifest-nrfxlib manifest-matter manifest-trusted-firmware-m manifest-openthread manifest-find-my labels Jul 17, 2023

jayteemo force-pushed the IRIS-4790 branch from 8394942 to f3d54f4 Compare July 17, 2023 23:25

jayteemo removed manifest-zephyr manifest-nrfxlib manifest-mcuboot manifest-trusted-firmware-m manifest-nrf-802154 manifest-find-my manifest-matter labels Jul 17, 2023

jayteemo force-pushed the IRIS-4790 branch 3 times, most recently from 7e85a88 to 1b61a48 Compare July 21, 2023 18:54

jayteemo marked this pull request as ready for review July 21, 2023 18:57

jayteemo force-pushed the IRIS-4790 branch from 1b61a48 to d73b143 Compare July 21, 2023 18:58

jayteemo requested review from plskeggs and glarsennordic July 21, 2023 18:58

jayteemo force-pushed the IRIS-4790 branch from d73b143 to 4b9d369 Compare July 24, 2023 22:10

glarsennordic reviewed Jul 25, 2023

View reviewed changes

jayteemo force-pushed the IRIS-4790 branch 2 times, most recently from 1ba8bbf to ad6a3eb Compare July 25, 2023 23:58

jayteemo requested a review from glarsennordic July 26, 2023 00:00

jayteemo force-pushed the IRIS-4790 branch from ad6a3eb to 468b41f Compare July 26, 2023 20:29

glarsennordic reviewed Jul 27, 2023

View reviewed changes

jayteemo force-pushed the IRIS-4790 branch 4 times, most recently from 029b7be to 59df208 Compare July 28, 2023 18:47

plskeggs approved these changes Jul 28, 2023

View reviewed changes

tests/subsys/net/lib/nrf_cloud/fota_common/src/fmfu.c Show resolved Hide resolved

jayteemo force-pushed the IRIS-4790 branch from 59df208 to a12c285 Compare August 1, 2023 17:12

tony-le-24 reviewed Aug 1, 2023

View reviewed changes

tests/subsys/net/lib/nrf_cloud/fota_common/src/main.c Outdated Show resolved Hide resolved

tony-le-24 approved these changes Aug 1, 2023

View reviewed changes

jayteemo force-pushed the IRIS-4790 branch 3 times, most recently from 63380be to e17b6a4 Compare August 1, 2023 22:16

tests: net: lib: nrf_cloud: add fota_common tests

1fe1eb7

Add test suite for nrf_cloud_fota_common.c. IRIS-4790 Signed-off-by: Justin Morton <[email protected]>

jayteemo force-pushed the IRIS-4790 branch from e17b6a4 to 1fe1eb7 Compare August 2, 2023 16:12

jayteemo removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 2, 2023

nordicjm merged commit e08b810 into nrfconnect:main Aug 3, 2023
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: net: lib: nrf_cloud: add fota_common tests #11734

tests: net: lib: nrf_cloud: add fota_common tests #11734

jayteemo commented Jul 6, 2023

NordicBuilder commented Jul 17, 2023

NordicBuilder commented Jul 21, 2023 •

edited

Loading

glarsennordic left a comment

glarsennordic Jul 27, 2023

jayteemo Jul 27, 2023

glarsennordic Jul 27, 2023

jayteemo Jul 28, 2023

glarsennordic Jul 27, 2023

jayteemo Jul 27, 2023

tony-le-24 left a comment

tests: net: lib: nrf_cloud: add fota_common tests #11734

tests: net: lib: nrf_cloud: add fota_common tests #11734

Conversation

jayteemo commented Jul 6, 2023

NordicBuilder commented Jul 17, 2023

NordicBuilder commented Jul 21, 2023 • edited Loading

Test specification

glarsennordic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tony-le-24 left a comment

Choose a reason for hiding this comment

NordicBuilder commented Jul 21, 2023 •

edited

Loading