Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: nsib: remove FEM mention and move some docs #12398

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

greg-fer
Copy link
Contributor

Removed mention of FEM from the NSIB readme.
Moved generic information about RoT establishment to bootloader docs. Part of NCSIDB-1053.

@greg-fer greg-fer added the CI-disable Disable CI for this PR label Sep 21, 2023
@greg-fer greg-fer added this to the 2.5.0 milestone Sep 21, 2023
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Sep 21, 2023
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

This public key is checked against the provisioned hashes of public keys to determine if the image is valid.

All public key hashes at lower indices than the matching hash are permanently invalidated at this point.
You can use this mechanism to decommission broken keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if broken is the right word here. Maybe stolen/cracked keys?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"compromised keys"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i like the suggestion above


All peripherals that have been used are reset and the next stage is booted.

Except for providing your own keys, there is no need to modify the immutable bootloader in any way before you program it.
Copy link
Contributor

@hellesvik-nordic hellesvik-nordic Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to modify the immutable bootloader in any way before you program it.

Something seems off with this statement.
I agree that you do not have to do this.
However, in several situations, it is beneficial to configure the immutable bootloader. To mention one: If you want MCUboot as an immutable bootloader with Serial Recovery enabled, you must configure it.

@hellesvik-nordic
Copy link
Contributor

For an general overview over my comments:
They all have the common thread that the steps are copied from specific NSIB docs to generic immutable bootloader docs.
The steps are therefore too specific to fit for generic immutable bootloader, and should be made less specific

@greg-fer
Copy link
Contributor Author

@sigvartmh , @hellesvik-nordic , @einarthorsrud , kindly please have another look.

Removed mention of FEM from the NSIB readme.
Moved generic information about RoT establishment to bootloader docs.
Part of NCSIDB-1053.

Signed-off-by: Grzegorz Ferenc <[email protected]>
@greg-fer greg-fer removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Sep 27, 2023
@rlubos rlubos merged commit 5a55ed9 into nrfconnect:main Sep 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-disable Disable CI for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants