-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: peripheral_uart: Fix hard-coded timeout value #12454
Conversation
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
Thanks for your contribution @pideu-mh. I check the reason why CI failed: 6: UC4 Commit message body line exceeds max length (75>72): "The initial init call, however, uses a hardcoded value of 50 (milliseconds)" Could you format your commit message according to above requirement? |
Calls to uart_rx_enable() require a timeout argument, for which UART_WAIT_FOR_RX is used in 2 of 3 calls in this application. The initial init call, however, uses a hardcoded value of 50 (milliseconds) instead of UART_WAIT_FOR_RX which is clearly an oversight. Signed-off-by: Michael Hunold <[email protected]>
I'm sorry for the additional work on your side. I have now reformatted the commit message and force pushed an update. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
One more thing. The PR target is wrong. This should go to ncs main branch. @pideu-mh Could you change PR target? |
@pideu-mh can you please retarget this PR against the |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Calls to uart_rx_enable() require a timeout argument, for which UART_WAIT_FOR_RX is used in 2 of 3 calls in this application.
The initial init call, however, uses a hardcoded value of 50 (milliseconds) instead of UART_WAIT_FOR_RX which is clearly an oversight.