Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: lib: download_client: Send error before disconnect #12555

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

SeppoTakalo
Copy link
Contributor

Send error event before disconnect event.
Disconnect event should be the last one.

This should fix the issue reported as NCSDK-23789.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 6, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 6, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-ci-nrfconnect-boot-fw-update X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@SeppoTakalo SeppoTakalo added this to the 2.5.0 milestone Oct 9, 2023
@SeppoTakalo SeppoTakalo removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 9, 2023
Send error event before disconnect event.
Disconnect event should be the last one.

Signed-off-by: Seppo Takalo <[email protected]>
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Oct 9, 2023
@SeppoTakalo SeppoTakalo removed the doc-required PR must not be merged without tech writer approval. label Oct 9, 2023
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@rlubos rlubos merged commit f4524b4 into nrfconnect:main Oct 9, 2023
17 of 19 checks passed
@SeppoTakalo SeppoTakalo deleted the NCSDK-23789 branch October 10, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants