Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsys: net: lib: nrf_cloud: Reuse socket for A-GNSS #12575

Merged

Conversation

tokangas
Copy link
Contributor

@tokangas tokangas commented Oct 9, 2023

A-GNSS data download usually requires more than one HTTP request. Now the same TCP/TLS connection is used for all HTTP requests.

@tokangas tokangas added this to the 2.5.0 milestone Oct 9, 2023
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 9, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 9, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

A-GNSS data download usually requires more than one HTTP request.
Now the same TCP/TLS connection is used for all HTTP requests.

Signed-off-by: Tommi Kangas <[email protected]>
@tokangas tokangas force-pushed the nrf_cloud_rest_agnss_reuse_socket branch from 5d2fe1d to 0900afc Compare October 9, 2023 10:04
Copy link
Contributor

@jayteemo jayteemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix 😅

@tokangas tokangas removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 10, 2023
@nordicjm nordicjm merged commit 8dfeca6 into nrfconnect:main Oct 10, 2023
18 checks passed
@tokangas tokangas deleted the nrf_cloud_rest_agnss_reuse_socket branch October 10, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants