applications: asset_tracker_v2: Replace hardcoded value with HW_ID_LEN
#12822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simensrostad
requested review from
gregersrygg,
jorgenmk,
maxd-nordic and
KajaKoren
simensrostad
requested review from
jhn-nordic and
coderbyheart
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
jtguggedal
approved these changes
Oct 23, 2023
jorgenmk
approved these changes
Oct 23, 2023
KajaKoren
approved these changes
Oct 23, 2023
gregersrygg
approved these changes
Oct 23, 2023
jorgenmk
requested changes
Oct 23, 2023
| @@ -15,7 +15,7 @@ | |||
| LOG_MODULE_REGISTER(MODULE, CONFIG_CLOUD_INTEGRATION_LOG_LEVEL); | |||
|
|
|||
| #if !defined(CONFIG_CLOUD_CLIENT_ID_USE_CUSTOM) | |||
| #define AWS_CLOUD_CLIENT_ID_LEN 15 | |||
| #define AWS_CLOUD_CLIENT_ID_LEN HW_ID_LEN | |||
There was a problem hiding this comment.
Works with (HW_ID_LEN - 1)
Replace hardcoded client ID with `HW_ID_LEN` to avoid truncating if HW ID library is configured to output IDs longer than 15 characters. Fixes NCSDK-24219 Signed-off-by: Simen S. Røstad <[email protected]>
simensrostad
force-pushed
the
at2/hw-id-len-fix
branch
from
4e76bad
to
4061bda
Compare
jorgenmk
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded client ID with
HW_ID_LENto avoid truncating if HW ID library is configured to output IDs longer than 15 characters.Fixes NCSDK-24219