Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: Add sidewalk to tag_west_repos.sh #12881

Merged
merged 1 commit into from
Dec 13, 2023
Merged

scripts: Add sidewalk to tag_west_repos.sh #12881

merged 1 commit into from
Dec 13, 2023

Conversation

cvinayak
Copy link
Contributor

Add sidewalk to tag_west_repos.sh.

@cvinayak cvinayak requested review from tejlmand and a team as code owners October 26, 2023 17:50
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 26, 2023
@NordicBuilder
Copy link
Contributor

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@mariusz-nordicsemi
Copy link
Contributor

Should sidewalk be added also to https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/releases_and_maturity/repository_revisions.rst ?

@cvinayak
Copy link
Contributor Author

cvinayak commented Oct 27, 2023 •
edited by peknis
Loading

Should sidewalk be added also to https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/releases_and_maturity/repository_revisions.rst ?

@peknis would you take care in a different PR?

No PR needed. Automation works.

@peknis
Copy link
Contributor

peknis commented Oct 27, 2023 •
edited
Loading

Should sidewalk be added also to https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/releases_and_maturity/repository_revisions.rst ?

Actually, this should have happened automatically, but the sidewalk repo was tagged a bit too late. Let's wait and see whether it happens later. If not, we can do this manually using this PR.

And after all, the automation worked.

@carlescufi
Copy link
Contributor

@cvinayak please rebase

@thst-nordic thst-nordic added the CI-disable Disable CI for this PR label Oct 31, 2023
@carlescufi
Copy link
Contributor

@cvinayak please rebase

@cvinayak
scripts: Add sidewalk to tag_west_repos.sh
c79b7f3 
Add sidewalk to tag_west_repos.sh.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak force-pushed the github_main_tag_west_repos_sidewalk branch from 5dc1d50 to c79b7f3 Compare December 7, 2023 08:03
@nordicjm nordicjm merged commit 4273acd into nrfconnect:main Dec 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanthanordic shanthanordic shanthanordic approved these changes

@mariusz-nordicsemi mariusz-nordicsemi mariusz-nordicsemi approved these changes

@nordicjm nordicjm nordicjm approved these changes

@rlubos rlubos rlubos approved these changes

@carlescufi carlescufi carlescufi approved these changes

@tejlmand tejlmand Awaiting requested review from tejlmand

@rakons rakons Awaiting requested review from rakons

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-disable Disable CI for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cvinayak @NordicBuilder @mariusz-nordicsemi @peknis @carlescufi @rlubos @nordicjm @shanthanordic @thst-nordic