samples: cellular: mss: Wait for connection before printing connected. #12901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
I still need to test CoAP, but I don't think the results will be different, so this should be ready for review |
plskeggs
approved these changes
Oct 28, 2023
glarsennordic
force-pushed
the
IRIS7090
branch
from
c8943c1
to
3684d49
Compare
|
Ah, right, changelog. I've spent too long on Zephyr PRs |
glarsennordic
force-pushed
the
IRIS7090
branch
2 times, most recently
from
4753693
to
9f269e9
Compare
github-actions
bot
added
doc-required
|
DNM until I test CoAP |
glarsennordic
force-pushed
the
IRIS7090
branch
from
9f269e9
to
55b68b7
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
peknis
requested changes
Oct 30, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
tony-le-24
approved these changes
Oct 31, 2023
jayteemo
approved these changes
Oct 31, 2023
MSS does not wait for connection success before printing "Connected to nRF Cloud". This commit fixes this by making the connect_cloud function correctly block until connection either succeeds or fails. IRIS-7090 Signed-off-by: Georges Oates_Larsen <[email protected]>
|
Tests succeed with CoAP |
glarsennordic
force-pushed
the
IRIS7090
branch
from
55b68b7
to
3755f01
Compare
peknis
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSS does not wait for connection success before printing "Connected to nRF Cloud".
This commit fixes this by making the connect_cloud function correctly block until connection either succeeds or fails.
IRIS-7090