Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fprotect rram basic support #15140

Merged
merged 3 commits into from
Jul 22, 2024
Merged

fprotect rram basic support #15140

merged 3 commits into from
Jul 22, 2024

Conversation

michalek-no
Copy link
Contributor

@michalek-no michalek-no commented Apr 30, 2024 •
edited
Loading

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 30, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 30, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@michalek-no
Copy link
Contributor Author

@sigvartmh please take a look if we can do something about nonhomogeneous PM/noPM partition names

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

nvlsianpu
nvlsianpu reviewed May 2, 2024
View reviewed changes
lib/fprotect/fprotect_rram.c Outdated Show resolved Hide resolved
lib/fprotect/Kconfig Show resolved Hide resolved
subsys/fw_info/Kconfig Outdated Show resolved Hide resolved
lib/fprotect/sys_init_fprotect.c Outdated
#ifdef CONFIG_PARTITION_MANAGER_ENABLED
#define CODE_PARTITION app
#else
#define CODE_PARTITION slot0_partition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't DT_CHOSEN(zephyr_code_partition) more generic assignment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can somehow get rid of this if-else block entirely. It's here because PM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we have PM and DTS for partitioning - not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't DT_CHOSEN(zephyr_code_partition) more generic assignment?

needs some additional stuff - on it's way nrfconnect/sdk-zephyr#1705

@nvlsianpu nvlsianpu requested a review from hubertmis May 7, 2024 10:15
hubertmis
hubertmis reviewed May 7, 2024
View reviewed changes
lib/fprotect/Kconfig Outdated Show resolved Hide resolved
lib/fprotect/fprotect_rram.c Outdated Show resolved Hide resolved
lib/fprotect/fprotect_rram.c Outdated Show resolved Hide resolved
lib/fprotect/fprotect_rram.c Outdated Show resolved Hide resolved
lib/fprotect/fprotect_rram.c Outdated Show resolved Hide resolved
lib/fprotect/fprotect_rram.c Outdated Show resolved Hide resolved
@michalek-no
Copy link
Contributor Author

rebase

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 10, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@af38d0b nrfconnect/sdk-zephyr@66628ac (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

hubertmis
hubertmis reviewed May 10, 2024
View reviewed changes
lib/fprotect/fprotect_rram.c Outdated Show resolved Hide resolved
lib/fprotect/fprotect_rram.c Outdated
*/
return -EINVAL;
}
if (size <= REGION_SIZE_MAX) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also check if RRAMC_REGION_FOR_FPROTECT is already in use. If it is, return -NOSPC

@github-actions github-actions bot removed the manifest label Jun 4, 2024
@michalek-no
Copy link
Contributor Author

rebase

@michalek-no michalek-no force-pushed the nrfx-mb-l15-boot-region branch 2 times, most recently from 5966ccf to 688b529 Compare June 17, 2024 13:44
@michalek-no
Copy link
Contributor Author

rebase

@michalek-no michalek-no changed the title fprotect draft fprotect rram basic support Jun 18, 2024
@michalek-no michalek-no removed the DNM label Jun 18, 2024
hubertmis
hubertmis approved these changes Jun 26, 2024
View reviewed changes
lib/fprotect/fprotect_rram.c Outdated Show resolved Hide resolved
@michalek-no michalek-no force-pushed the nrfx-mb-l15-boot-region branch 3 times, most recently from 3cebddb to 4059f2a Compare June 27, 2024 07:53
@michalek-no
Copy link
Contributor Author

rebase

@michalek-no
lib: fprotect: RRAMC region protection
548480f 
Introduces backend and adjusts configuration to add
fprotect for nRF54L15.

Signed-off-by: Mateusz Michalek <[email protected]>
@michalek-no
tests: drivers: fprotect: nRF54L15 specific
883624d 
Due to RRAMC region protection size limitations
test is performed on single block of storage partition.

Signed-off-by: Mateusz Michalek <[email protected]>
@michalek-no
Copy link
Contributor Author

rebase

@michalek-no
manifest: update sdk-zephyr
deff1ad 
pulling 4k rramc resolution changes.

Signed-off-by: Mateusz Michalek <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Jul 22, 2024
@rlubos rlubos merged commit a579ba4 into nrfconnect:main Jul 22, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertmis hubertmis hubertmis approved these changes

@nvlsianpu nvlsianpu nvlsianpu approved these changes

@sigvartmh sigvartmh Awaiting requested review from sigvartmh

@de-nordic de-nordic Awaiting requested review from de-nordic

@gchwier gchwier Awaiting requested review from gchwier

@hakonfam hakonfam Awaiting requested review from hakonfam

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

@oyvindronningstad oyvindronningstad Awaiting requested review from oyvindronningstad

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-mcuboot manifest-zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michalek-no @NordicBuilder @oyvindronningstad @nvlsianpu @hubertmis @rlubos