Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wi-Fi and Thread coexistence sample #15292

Merged

Conversation

muraliThokala
Copy link
Contributor

Initial version of the Wi-Fi and Thread coexistence sample.
This sample is to run Wi-Fi and Thread throughputs simultaneously
to show how they coexist.
Wi-Fi in station mode connects to Wi-Fi AP and runs Zperf.
Thread in child mode connects to leader and runs Zperf.

@muraliThokala muraliThokala requested review from a team and carlescufi as code owners May 14, 2024 09:50
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 14, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 14, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@muraliThokala muraliThokala marked this pull request as draft May 14, 2024 11:36
@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch from 5b15b2f to 7fdac70 Compare May 17, 2024 05:16
@muraliThokala muraliThokala marked this pull request as ready for review May 17, 2024 10:58
@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch from 7fdac70 to e7fc6bd Compare May 17, 2024 11:01
@muraliThokala muraliThokala added this to the 2.7.0 milestone May 17, 2024
@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch 10 times, most recently from db4f893 to 1a6afeb Compare May 20, 2024 17:46
@umapraseeda
Copy link
Contributor

@gmarull, could you check why we are getting the compliance error: https://github.com/nrfconnect/sdk-nrf/actions/runs/9162785903/job/25190487286?pr=15292. The image is already in the excluded path. Also, the line endings are already LF and not CRLF.

@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch from 1a6afeb to edaf034 Compare May 21, 2024 07:19
@gmarull
Copy link
Member

gmarull commented May 21, 2024

@gmarull, could you check why we are getting the compliance error: https://github.com/nrfconnect/sdk-nrf/actions/runs/9162785903/job/25190487286?pr=15292. The image is already in the excluded path. Also, the line endings are already LF and not CRLF.

can be ignored, we should not check SVG files cc: @carlescufi

@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch from edaf034 to 5b4aa8d Compare May 22, 2024 06:52
Copy link
Contributor

@richabp richabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a new sample, please add the Changelog entry.

samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch 3 times, most recently from 230b976 to 79a82aa Compare May 22, 2024 13:06
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
samples/wifi/thread_coex/README.rst Outdated Show resolved Hide resolved
@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch 7 times, most recently from f75db4f to 51e2c60 Compare May 26, 2024 11:26
samples/wifi/thread_coex/Kconfig Show resolved Hide resolved
samples/wifi/thread_coex/Kconfig Outdated Show resolved Hide resolved
samples/wifi/thread_coex/child_image/802154_rpmsg.conf Outdated Show resolved Hide resolved
samples/wifi/thread_coex/src/main.c Outdated Show resolved Hide resolved
@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch 2 times, most recently from fe8e682 to 4a022f7 Compare May 27, 2024 05:38
Copy link
Contributor

@bama-nordic bama-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch from 4a022f7 to 3079207 Compare May 27, 2024 09:54
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 27, 2024
@krish2718
Copy link
Contributor

BTW, I have just realized that there is no sysbuild support for this sample, sysbuild is now default in NCS, so, please add support.

@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch 9 times, most recently from 2cf3dfa to 00ac579 Compare May 29, 2024 06:40
Initial version of the Wi-Fi and Thread coexistence sample.

This sample is to run Wi-Fi and Thread throughputs simultaneously
to show how they coexist.

Wi-Fi in station mode connects to Wi-Fi AP and runs Zperf.
Thread in child mode connects to leader and runs Zperf.

Signed-off-by: Murali Thokala <[email protected]>
@muraliThokala muraliThokala force-pushed the wifi_thread_coexistence_rel_2.7.0 branch from 00ac579 to acee5eb Compare May 29, 2024 11:24
@rlubos rlubos merged commit 8d6236f into nrfconnect:main Jun 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants