Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-M and Crypto samples: add 9161 support #15409

Merged
merged 4 commits into from
May 31, 2024

Conversation

juhaylinen
Copy link
Contributor

  • Add 9161 support to t-fm samples and tests
  • Add 9161 support to crypto tests and samples

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 21, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 21, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf_crypto X
test-fw-nrfconnect-tfm X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@MarkusLassila MarkusLassila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 22, 2024
@juhaylinen juhaylinen requested a review from melwee01 May 22, 2024 11:29
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 23, 2024
@juhaylinen juhaylinen added this to the 2.7.0 milestone May 23, 2024
@juhaylinen juhaylinen requested a review from mia-ko May 28, 2024 07:37
@juhaylinen juhaylinen force-pushed the tfm_samples_9161dk branch 3 times, most recently from 5954606 to 247233e Compare May 29, 2024 06:58
@@ -692,7 +692,7 @@ Sensor samples
Trusted Firmware-M (TF-M) samples
---------------------------------

* Added support for the :ref:`zephyr:nrf9151dk_nrf9151` board for all TF-M samples.
* Added support for the :ref:`zephyr:nrf9151dk_nrf9151` and the :ref:`nRF9161 DK <ug_nrf9161>` boards for all TF-M samples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added support for the :ref:`zephyr:nrf9151dk_nrf9151` and the :ref:`nRF9161 DK <ug_nrf9161>` boards for all TF-M samples.
* Added support for the :ref:`zephyr:nrf9151dk_nrf9151` and the :ref:`nRF9161 DK <ug_nrf9161>` boards for all TF-M samples (except for the :ref:`provisioning_image_net_core` sample).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add a bullet point after line 533 (under the Cryptography samples section)

Support for the :ref:nRF9161 DK <ug_nrf9161> board for the :ref:crypto_test sample.

Add nrf9161 support to tf-m samples and tests.

Signed-off-by: Juha Ylinen <[email protected]>
This fixes following error when the sample is run.
psa_import_key failed. (Error: -134)

Enable immediate log mode for RNG and RSA samples to prevent
log messages being dropped.

Signed-off-by: Juha Ylinen <[email protected]>
Add nrf9161dk to supported platforms.

Signed-off-by: Juha Ylinen <[email protected]>
Add nRF9161dk support to TF-M samples.

Signed-off-by: Juha Ylinen <[email protected]>
@juhaylinen juhaylinen removed the doc-required PR must not be merged without tech writer approval. label May 30, 2024
@rlubos rlubos merged commit cd3b204 into nrfconnect:main May 31, 2024
16 checks passed
@juhaylinen juhaylinen deleted the tfm_samples_9161dk branch May 31, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants