samples: applications: Use ipc_radio as default radio firmware. #15435

dchat-nordic · 2024-05-22T07:10:51Z

Use ipc_radio as default radio firmware.

test_audio: PR-259
test_chip: PR-760
test_thread: PR-1172

NordicBuilder · 2024-05-22T07:16:38Z

Test specification

CI/Jenkins/NRF

Integration Platforms

CI/Jenkins/integration

Test Module	File based changes	Manually selected	West overwrite
desktop52_verification	X
test-fw-nrfconnect-apps	X
test-fw-nrfconnect-ble_mesh	X
test-fw-nrfconnect-ble_samples	X
test-fw-nrfconnect-chip	X
test-fw-nrfconnect-nfc	X
test-fw-nrfconnect-thread	X
test-fw-nrfconnect-zigbee	X
test-sdk-audio	X
test-sdk-dfu	X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

samples/matter/lock/Kconfig.sysbuild

samples/matter/lock/sysbuild/ipc_radio/boards/nrf7002dk_nrf5340_cpuapp nrf7001.conf

ArekBalysNordic

Thanks!

LuDuda

Thank you! 👍

NordicBuilder · 2024-05-22T08:38:42Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

kapi-no

Approving the Fast Pair part

greg-fer · 2024-05-27T06:32:39Z

samples/openthread/cli/README.rst

@@ -105,7 +105,7 @@ The following snippets are available:
  Not compatible with the ``tcat`` snippet.

  .. note::
-    When building with the ``multiprotocol`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` build target, the :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` Kconfig option has to be set to ``y``.
+    When building with the ``multiprotocol`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the :makevar:`FILE_SUFFIX` CMake variable to ``ble``.


Suggested change

When building with the ``multiprotocol`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the :makevar:`FILE_SUFFIX` CMake variable to ``ble``.

When building with the ``multiprotocol`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the :makevar:`FILE_SUFFIX` CMake option to ``ble``.

See :ref:`app_build_file_suffixes` and :ref:`cmake_options` for more information.

greg-fer · 2024-05-27T06:33:57Z

samples/openthread/coap_client/README.rst

@@ -129,7 +129,7 @@ The following snippets are available:
 * ``multiprotocol_ble`` - Enables the Multiprotocol Bluetooth LE extension.

  .. note::
-    When building with ``multiprotocol_ble`` snippet, for the ``nrf5340dk/nrf5340/cpuapp`` build target, additional :kconfig:option:`SB_CONFIG_NETCORE_MULTIPROTOCOL_RPMSG` option has to be set.
+    When building with the ``multiprotocol_ble`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the additional :makevar:`FILE_SUFFIX` CMake variable to ``ble``.


Suggested change

When building with the ``multiprotocol_ble`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the additional :makevar:`FILE_SUFFIX` CMake variable to ``ble``.

When building with the ``multiprotocol_ble`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the additional :makevar:`FILE_SUFFIX` CMake option to ``ble``.

See :ref:`app_build_file_suffixes` and :ref:`cmake_options` for more information.

maciejbaczmanski

certification.rst for Thread protocol should be modified as well in two places:
https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/protocols/thread/certification.rst?plain=1#L70

https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/protocols/thread/certification.rst?plain=1#L89

doc/nrf/protocols/thread/certification.rst

alstrzebonski

I don't like the current approach. Earlier we had an abstraction of having NRF_DEFAULT_BLUETOOTH option - sample was declaring that it wants to have Bluetooth. Now we have samples that enables NRF_DEFAULT_IPC_RADIO also for targets with one core which looks odd. Maybe we could just change defaults in choice NETCORE in sysbuild/Kconfig.netcore so that NETCORE would default to NETCORE_IPC_RADIO if NRF_DEFAULT_BLUETOOTH is enabled and we could introduce the NRF_DEFAULT_HCI_IPC option that would default the NETCORE to NETCORE_HCI_IPC (NRF_DEFAULT_HCI_IPC would be doing what NRF_DEAFULT_BLUETOOTH is doing now).

dchat-nordic · 2024-05-28T09:34:43Z

I don't like the current approach. Earlier we had an abstraction of having NRF_DEFAULT_BLUETOOTH option - sample was declaring that it wants to have Bluetooth. Now we have samples that enables NRF_DEFAULT_IPC_RADIO also for targets with one core which looks odd. Maybe we could just change defaults in choice NETCORE in sysbuild/Kconfig.netcore so that NETCORE would default to NETCORE_IPC_RADIO if NRF_DEFAULT_BLUETOOTH is enabled and we could introduce the NRF_DEFAULT_HCI_IPC option that would default the NETCORE to NETCORE_HCI_IPC.

The current approach has merit, because it explicitly states which application is used.
Moreover, in case of zigbee samples declaring NRF_DEFAULT_BLUETOOTH would be at the least confusing.

alstrzebonski · 2024-05-28T09:39:39Z

I don't like the current approach. Earlier we had an abstraction of having NRF_DEFAULT_BLUETOOTH option - sample was declaring that it wants to have Bluetooth. Now we have samples that enables NRF_DEFAULT_IPC_RADIO also for targets with one core which looks odd. Maybe we could just change defaults in choice NETCORE in sysbuild/Kconfig.netcore so that NETCORE would default to NETCORE_IPC_RADIO if NRF_DEFAULT_BLUETOOTH is enabled and we could introduce the NRF_DEFAULT_HCI_IPC option that would default the NETCORE to NETCORE_HCI_IPC.

The current approach has merit, because it explicitly states which application is used. Moreover, in case of zigbee samples declaring NRF_DEFAULT_BLUETOOTH would be at the least confusing.

Enabling NRF_DEFAULT_IPC_RADIO for one-core targets just looks bad for me. Zigbee could still enable NRF_DEFAULT_IPC_RADIO if it doesn't want to rely on default option ( NRF_DEFAULT_BLUETOOTH).

dchat-nordic · 2024-05-28T09:48:57Z

I don't like the current approach. Earlier we had an abstraction of having NRF_DEFAULT_BLUETOOTH option - sample was declaring that it wants to have Bluetooth. Now we have samples that enables NRF_DEFAULT_IPC_RADIO also for targets with one core which looks odd. Maybe we could just change defaults in choice NETCORE in sysbuild/Kconfig.netcore so that NETCORE would default to NETCORE_IPC_RADIO if NRF_DEFAULT_BLUETOOTH is enabled and we could introduce the NRF_DEFAULT_HCI_IPC option that would default the NETCORE to NETCORE_HCI_IPC.

The current approach has merit, because it explicitly states which application is used. Moreover, in case of zigbee samples declaring NRF_DEFAULT_BLUETOOTH would be at the least confusing.

Enabling NRF_DEFAULT_IPC_RADIO for one-core targets just looks bad for me. Zigbee could still enable NRF_DEFAULT_IPC_RADIO if it doesn't want to rely on default option ( NRF_DEFAULT_BLUETOOTH).

None of the network core images specified in

sdk-nrf/sysbuild/Kconfig.netcore

Line 66 in e5e367d

choice NETCORE

is ever enabled for single-core devices because of dependecies and ifs specified in said file.

Use ipc_radio as default radio firmware over: -hci_ipc -multiprotocol_rpmsg -802154_rpmsg Jira: NCSDK-27179 Co-authored-by: Kamil Gawor <[email protected]> Signed-off-by: Dominik Chat <[email protected]>

kapi-no · 2024-05-29T08:59:33Z

I don't like the current approach. Earlier we had an abstraction of having NRF_DEFAULT_BLUETOOTH option - sample was declaring that it wants to have Bluetooth. Now we have samples that enables NRF_DEFAULT_IPC_RADIO also for targets with one core which looks odd. Maybe we could just change defaults in choice NETCORE in sysbuild/Kconfig.netcore so that NETCORE would default to NETCORE_IPC_RADIO if NRF_DEFAULT_BLUETOOTH is enabled and we could introduce the NRF_DEFAULT_HCI_IPC option that would default the NETCORE to NETCORE_HCI_IPC.

The current approach has merit, because it explicitly states which application is used. Moreover, in case of zigbee samples declaring NRF_DEFAULT_BLUETOOTH would be at the least confusing.

Enabling NRF_DEFAULT_IPC_RADIO for one-core targets just looks bad for me. Zigbee could still enable NRF_DEFAULT_IPC_RADIO if it doesn't want to rely on default option ( NRF_DEFAULT_BLUETOOTH).

None of the network core images specified in

sdk-nrf/sysbuild/Kconfig.netcore

Line 66 in e5e367d

choice NETCORE

is ever enabled for single-core devices because of dependecies and ifs specified in said file.

The NRF_DEFAULT_IPC_RADIO option is an independent option that is not part of the choice NETCORE and is enabled for nRF52 devices.

dchat-nordic requested review from milewr, Damian-Nordic, kkasperczyk-no, alstrzebonski, MarekPieta, kapi-no, ppryga-nordic, ludvigsj, alwa-nordic, jori-nordic, carlescufi, KAGA164 and tejlmand as code owners May 22, 2024 07:10

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 22, 2024

dchat-nordic requested review from nordicjm and maje-emb May 22, 2024 07:11

KAGA164 approved these changes May 22, 2024

View reviewed changes

maje-emb approved these changes May 22, 2024

View reviewed changes

ArekBalysNordic requested changes May 22, 2024

View reviewed changes

samples/matter/lock/Kconfig.sysbuild Show resolved Hide resolved

dchat-nordic force-pushed the fix_ipc_radio branch from 9688e7a to 2985a57 Compare May 22, 2024 07:45

dchat-nordic requested a review from ArekBalysNordic May 22, 2024 07:45

ArekBalysNordic approved these changes May 22, 2024

View reviewed changes

ArekBalysNordic requested changes May 22, 2024

View reviewed changes

samples/matter/lock/sysbuild/ipc_radio/boards/nrf7002dk_nrf5340_cpuapp nrf7001.conf Outdated Show resolved Hide resolved

dchat-nordic force-pushed the fix_ipc_radio branch from 2985a57 to 441ecc9 Compare May 22, 2024 08:00

ArekBalysNordic approved these changes May 22, 2024

View reviewed changes

LuDuda approved these changes May 22, 2024

View reviewed changes

kapi-no approved these changes May 22, 2024

View reviewed changes

dchat-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 22, 2024

dchat-nordic requested a review from peknis May 24, 2024 12:08

peknis approved these changes May 27, 2024

View reviewed changes

greg-fer requested changes May 27, 2024

View reviewed changes

maciejbaczmanski reviewed May 27, 2024

View reviewed changes

dchat-nordic force-pushed the fix_ipc_radio branch from 82d1054 to ee0f1bf Compare May 28, 2024 08:07

dchat-nordic requested a review from a team as a code owner May 28, 2024 08:07

dchat-nordic force-pushed the fix_ipc_radio branch from ee0f1bf to f0c8a48 Compare May 28, 2024 08:55

dchat-nordic requested a review from wiba-nordic as a code owner May 28, 2024 08:55

dchat-nordic requested review from greg-fer and maciejbaczmanski May 28, 2024 08:55

wiba-nordic requested changes May 28, 2024

View reviewed changes

doc/nrf/protocols/thread/certification.rst Outdated Show resolved Hide resolved

dchat-nordic force-pushed the fix_ipc_radio branch from f0c8a48 to 54b9d87 Compare May 28, 2024 09:02

dchat-nordic requested a review from wiba-nordic May 28, 2024 09:02

wiba-nordic approved these changes May 28, 2024

View reviewed changes

alstrzebonski reviewed May 28, 2024

View reviewed changes

dchat-nordic force-pushed the fix_ipc_radio branch from 54b9d87 to 65f50c0 Compare May 28, 2024 09:47

dchat-nordic force-pushed the fix_ipc_radio branch from 65f50c0 to 7213c2e Compare May 28, 2024 12:24

dchat-nordic removed the DNM label May 28, 2024

dchat-nordic requested a review from alstrzebonski May 28, 2024 13:45

greg-fer approved these changes May 29, 2024

View reviewed changes

samples: applications: Use ipc_radio as default radio firmware.

ed37217

Use ipc_radio as default radio firmware over: -hci_ipc -multiprotocol_rpmsg -802154_rpmsg Jira: NCSDK-27179 Co-authored-by: Kamil Gawor <[email protected]> Signed-off-by: Dominik Chat <[email protected]>

dchat-nordic force-pushed the fix_ipc_radio branch from 7213c2e to ed37217 Compare May 29, 2024 09:00

rlubos merged commit b60b107 into nrfconnect:main May 29, 2024
23 checks passed

wentong-li mentioned this pull request Jun 3, 2024

sample: wifi_privisioning: add missing sysbuild file #15633

Merged

dchat-nordic mentioned this pull request Jun 3, 2024

samples: wifi: Switch BLE/IEEE802154 radio firmware to ipc_radio #15656

Merged

ktaborowski mentioned this pull request Jun 4, 2024

samples: Replace hci_ipc with ipc_radio for sysbuild. nrfconnect/sdk-sidewalk#566

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: applications: Use ipc_radio as default radio firmware. #15435

samples: applications: Use ipc_radio as default radio firmware. #15435

dchat-nordic commented May 22, 2024 •

edited

Loading

NordicBuilder commented May 22, 2024 •

edited

Loading

ArekBalysNordic left a comment

LuDuda left a comment

NordicBuilder commented May 22, 2024

kapi-no left a comment

greg-fer May 27, 2024

greg-fer May 27, 2024

maciejbaczmanski left a comment

alstrzebonski left a comment •

edited

Loading

dchat-nordic commented May 28, 2024

alstrzebonski commented May 28, 2024 •

edited

Loading

dchat-nordic commented May 28, 2024

kapi-no commented May 29, 2024

	When building with the ``multiprotocol`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the :makevar:`FILE_SUFFIX` CMake variable to ``ble``.
	When building with the ``multiprotocol`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the :makevar:`FILE_SUFFIX` CMake option to ``ble``.
	See :ref:`app_build_file_suffixes` and :ref:`cmake_options` for more information.

	When building with the ``multiprotocol_ble`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the additional :makevar:`FILE_SUFFIX` CMake variable to ``ble``.
	When building with the ``multiprotocol_ble`` snippet for the ``nrf5340dk/nrf5340/cpuapp`` board target, set the additional :makevar:`FILE_SUFFIX` CMake option to ``ble``.
	See :ref:`app_build_file_suffixes` and :ref:`cmake_options` for more information.

samples: applications: Use ipc_radio as default radio firmware. #15435

samples: applications: Use ipc_radio as default radio firmware. #15435

Conversation

dchat-nordic commented May 22, 2024 • edited Loading

NordicBuilder commented May 22, 2024 • edited Loading

Test specification

CI/Jenkins/NRF

CI/Jenkins/integration

ArekBalysNordic left a comment

Choose a reason for hiding this comment

LuDuda left a comment

Choose a reason for hiding this comment

NordicBuilder commented May 22, 2024

kapi-no left a comment

Choose a reason for hiding this comment

greg-fer May 27, 2024

Choose a reason for hiding this comment

greg-fer May 27, 2024

Choose a reason for hiding this comment

maciejbaczmanski left a comment

Choose a reason for hiding this comment

alstrzebonski left a comment • edited Loading

Choose a reason for hiding this comment

dchat-nordic commented May 28, 2024

alstrzebonski commented May 28, 2024 • edited Loading

dchat-nordic commented May 28, 2024

kapi-no commented May 29, 2024

dchat-nordic commented May 22, 2024 •

edited

Loading

NordicBuilder commented May 22, 2024 •

edited

Loading

alstrzebonski left a comment •

edited

Loading

alstrzebonski commented May 28, 2024 •

edited

Loading