applications: nrf5340_audio: Rewrite adv population for broadcast_source #15469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
alexsven
reviewed
May 24, 2024
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
koffes
requested changes
May 24, 2024
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.h
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/unicast/unicast_server.c
Outdated
Show resolved
Hide resolved
alexsven
requested changes
May 24, 2024
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/unicast/unicast_server.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_management/bt_mgmt.h
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_management/bt_mgmt.h
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
40041d0
to
74078f7
Compare
alexsven
requested changes
May 27, 2024
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.h
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.h
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_management/bt_mgmt.h
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.h
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/unicast/unicast_server.c
Outdated
Show resolved
Hide resolved
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
74078f7
to
c97d2f3
Compare
koffes
requested changes
May 30, 2024
applications/nrf5340_audio/src/bluetooth/bt_stream/unicast/unicast_server.c
Show resolved
Hide resolved
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
c97d2f3
to
a5e78f2
Compare
koffes
approved these changes
May 31, 2024
alexsven
requested changes
May 31, 2024
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_management/bt_mgmt.c
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Outdated
Show resolved
Hide resolved
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
a5e78f2
to
b52681a
Compare
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
b52681a
to
ecfba7c
Compare
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
ecfba7c
to
1b91b7c
Compare
alexsven
requested changes
Jun 5, 2024
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.c
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/Kconfig
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_management/bt_mgmt.h
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.h
Outdated
Show resolved
Hide resolved
applications/nrf5340_audio/src/bluetooth/bt_stream/broadcast/broadcast_source.h
Outdated
Show resolved
Hide resolved
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
1b91b7c
to
e7fd88f
Compare
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
2 times, most recently
from
b0142fe
to
553e19a
Compare
alexsven
approved these changes
Jun 6, 2024
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
553e19a
to
f1c17c6
Compare
While adding the manufacturer ID in the advertisement packet it was noticed that the adv packet for unicast_client and broadcast_source are done in completely different ways. This rewrites both to make them closer and with a view to setting these later with a shell. Signed-off-by: Graham Wacey <[email protected]>
gWacey
force-pushed
the
OCT-2949-Rewrite-adv-population-for-broadcast_source
branch
from
b18633e
to
8a83cb9
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCT-2949
While adding the manufacturer ID in the advertisement packet it was noticed that the adv packet for unicast_client and broadcast_source are done in completely different ways. This rewrites both to make them closer and with a view to setting these later with a shell.
The implementation has moved any Kconfig CONFIG_* into the populate routine in preparation for driving externally.