samples: matter: Introduce Timed Schedule Access in Lock #15485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
requested review from
Damian-Nordic,
kkasperczyk-no and
carlescufi
as code owners
github-actions
bot
added
the
doc-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
from
184ac87
to
52979e8
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
samples/matter/lock/src/credentials/credentials_manager_schedules.cpp
Outdated
Show resolved
Hide resolved
samples/matter/lock/src/credentials/credentials_manager_schedules.cpp
Outdated
Show resolved
Hide resolved
wiba-nordic
requested changes
May 24, 2024
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
2 times, most recently
from
8b785d3
to
d47a11d
Compare
Damian-Nordic
approved these changes
May 24, 2024
samples/matter/lock/src/credentials/credentials_manager_schedules.cpp
Outdated
Show resolved
Hide resolved
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
from
d47a11d
to
084465b
Compare
wiba-nordic
requested changes
May 24, 2024
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
from
bc21463
to
a23ac69
Compare
wiba-nordic
requested changes
May 27, 2024
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
2 times, most recently
from
caad01e
to
2ef70ee
Compare
wiba-nordic
approved these changes
May 28, 2024
samples/matter/lock/src/credentials/credentials_manager_credentials.cpp
Outdated
Show resolved
Hide resolved
| @@ -32,6 +55,15 @@ config LOCK_ENABLE_DEBUG | |||
|
|
|||
| if LOCK_ENABLE_DEBUG | |||
|
|
|||
| config LOCK_PRINT_STORAGE_STATUS | |||
There was a problem hiding this comment.
Is it used anywhere? I can't find it.
There was a problem hiding this comment.
It is used in the credentials_storage.cpp please check one more time. Previously it was used but never defined in Kconfig. It is a fix for that.
samples/matter/lock/src/credentials/credentials_manager_schedules.cpp
Outdated
Show resolved
Hide resolved
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
from
2ef70ee
to
5ffd41c
Compare
|
@kkasperczyk-no I've changed the naming from credentials to access, please review the recent changes. |
Did you check if we mention the module elsewhere in the documentation? |
I found several places, however I hope I've replaced all of them. |
1 task
wiba-nordic
requested changes
May 28, 2024
wiba-nordic
approved these changes
May 28, 2024
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
from
e2a6ff4
to
590346e
Compare
kkasperczyk-no
approved these changes
May 29, 2024
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
from
590346e
to
96856d8
Compare
- Regenerated Matter Lock Zap to include Timed Schedule Access feature - Added Schedules for WeekDay, YearDay and Holiday to the credentials manager according to Matter Specification. - Implemented callbacks for the schedule feature required by door-lock-server. - Moved credentials manager users, schedules and credentials implementations to separate files due to a high number of lines in the credentials_manager.cpp file. - Added a guide to Matter Lock sample on how to use this feature. - Added guide how to enable the timed-access schedule feature - Updated release notes. - Changed names from credentials to access Signed-off-by: Arkadiusz Balys <[email protected]>
Added description on how to enable Time Synchronization cluster with all required types. Signed-off-by: Marcin Kajor <[email protected]>
ArekBalysNordic
force-pushed
the
schedule-timed-access
branch
from
96856d8
to
197438b
Compare
markaj-nordic
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated Matter Lock Zap to include Timed Schedule Access feature
Added Schedules for WeekDay, YearDay and Holiday to the credentials manager according to Matter
Specification.
Implemented callbacks for the schedule feature required by door-lock-server.
Moved credentials manager users, schedules and credentials implementations to separate files due to a high number of lines in the credentials_manager.cpp file.
Added a guide to Matter Lock sample on how to use this feature.
Updated release notes.