applications: serial_lte_modem: check for uninitialized send callback #15546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperradoszewski
requested review from
SeppoTakalo,
MarkusLassila,
rlubos and
tomi-font
as code owners
github-actions
bot
added
the
changelog-entry-required
SeppoTakalo
approved these changes
May 28, 2024
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
MarkusLassila
approved these changes
May 28, 2024
There was a problem hiding this comment.
@kacperradoszewski: This will fail until this PR goes in: #15467
kacperradoszewski
removed
the
changelog-entry-required
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
junqingzou
approved these changes
May 28, 2024
tomi-font
approved these changes
May 29, 2024
Calling slm_at_send_indicate() before the AT backend is initialized will dereference a NULL pointer, which may happen as several modules can dispatch custom notifications at any point. Signed-off-by: Kacper Radoszewski <[email protected]>
kacperradoszewski
force-pushed
the
bugfix/NCSDK-NONE/slm-check-backend-send
branch
from
1501280
to
2233244
Compare
github-actions
bot
added
the
changelog-entry-required
kacperradoszewski
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling slm_at_send_indicate() before the AT backend is initialized will dereference a NULL pointer, which may happen as several modules can dispatch custom notifications at any point.