Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wi-Fi ready event library #15628

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Add Wi-Fi ready event library #15628

merged 4 commits into from
Jun 6, 2024

Conversation

D-Triveni
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 1, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 1, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-boot X
test-sdk-mcuboot X
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

krish2718
krish2718 requested changes Jun 3, 2024
View reviewed changes
include/net/wifi_ready.h Outdated Show resolved Hide resolved
include/net/wifi_ready.h Outdated Show resolved Hide resolved
include/net/wifi_ready.h Show resolved Hide resolved
include/net/wifi_ready.h Outdated Show resolved Hide resolved
include/net/wifi_ready.h Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
samples/wifi/sta/src/main.c Outdated Show resolved Hide resolved
samples/wifi/sta/src/main.c Outdated Show resolved Hide resolved
@sachinthegreen sachinthegreen added this to the 2.7.0 milestone Jun 3, 2024
sachinthegreen
sachinthegreen requested changes Jun 3, 2024
View reviewed changes
subsys/net/lib/wifi_ready/Kconfig Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Show resolved Hide resolved
@D-Triveni D-Triveni force-pushed the add_wifi_ready_evnt_lib branch 5 times, most recently from 03ec439 to 9620226 Compare June 5, 2024 10:06
sachinthegreen
sachinthegreen requested changes Jun 5, 2024
View reviewed changes
samples/wifi/sta/src/main.c Outdated Show resolved Hide resolved
samples/wifi/sta/src/main.c Outdated Show resolved Hide resolved
samples/wifi/sta/src/main.c Outdated Show resolved Hide resolved
krish2718
krish2718 reviewed Jun 5, 2024
View reviewed changes
samples/wifi/sta/Kconfig Outdated Show resolved Hide resolved
samples/wifi/sta/src/main.c Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/Kconfig Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/Kconfig Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
subsys/net/lib/wifi_ready/wifi_ready.c Outdated Show resolved Hide resolved
@D-Triveni D-Triveni force-pushed the add_wifi_ready_evnt_lib branch 2 times, most recently from 8a18522 to fa91c80 Compare June 5, 2024 12:47
@krish2718 krish2718 force-pushed the add_wifi_ready_evnt_lib branch 2 times, most recently from ff4c44d to 28ddc13 Compare June 6, 2024 06:17
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jun 6, 2024
@D-Triveni D-Triveni requested a review from peknis June 6, 2024 06:28
@peknis
Copy link
Contributor

peknis commented Jun 6, 2024 •
edited
Loading

Add also the changelog entry for the new library.

@krish2718
Copy link
Contributor

Add also the changelog entry for the new library.

To avoid CI re-trigger and merge this PR before RC1, it is being done in a separate PR https://github.com/nrfconnect/sdk-nrf/pull/15765/files.

@peknis
Copy link
Contributor

peknis commented Jun 6, 2024 •
edited
Loading

Add also the changelog entry for the new library.

To avoid CI re-trigger and merge this PR before RC1, it is being done in a separate PR https://github.com/nrfconnect/sdk-nrf/pull/15765/files.

No point to have that in a different PR. Just add it here and you will be fine. It takes a bit time, but let's do this properly. The doc build failure here is a mystery. Maybe a rebase would be good.

@krish2718
Copy link
Contributor

Add also the changelog entry for the new library.

To avoid CI re-trigger and merge this PR before RC1, it is being done in a separate PR https://github.com/nrfconnect/sdk-nrf/pull/15765/files.

No point to have that in a different PR. Just add it here and you will be fine. It takes a bit time, but let's do this properly. The doc build failure here is a mystery. Maybe a rebase would be good.

Sure, I need to push a fix (doxygen endcond missing) to doc build anyways, jusy waiting for twister to complete to see if there are any other failures.

@peknis
Copy link
Contributor

peknis commented Jun 6, 2024

Okay, the changelog entry seems to already be in 15765, so do not add it in this PR anymore.

D-Triveni and others added 4 commits June 6, 2024 13:11
@D-Triveni @krish2718
net: lib: Add wifi_ready library
1d07d7f 
Add wifi_ready library to monitor supplicant events
and ensure applications wait for Wi-Fi readiness both at boot time and
also at run time.

Implements SHEL-2741.

Signed-off-by: Triveni Danda <[email protected]>
Signed-off-by: Chaitanya Tata <[email protected]>
@D-Triveni @krish2718
samples: wifi: sta: Use Wi-Fi ready library
d0152ba 
Update the sample application to use newly introduced Wi-Fi ready
library, this ensures that application uses Wi-Fi only when it's
available both at boot time and run time.

Implement demo usage for SHEL-2741 and enable it by default, except
for nRF52840DK as it as low RAM.

Signed-off-by: Triveni Danda <[email protected]>
Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
doc: changelog: Add an entry for Wi-Fi ready library
ba9a2fe 
Add Wi-Fi library to networking libraries section.

Signed-off-by: Chaitanya Tata <[email protected]>
@D-Triveni @krish2718
doc: changelog: Add entry for station sample
f1c2c7b 
Add changelog entry for the STA sample to migrate to Wi-Fi ready
library.

Signed-off-by: Triveni Danda <[email protected]>
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 6, 2024
@krish2718 krish2718 mentioned this pull request Jun 6, 2024
Closed
@krish2718
Copy link
Contributor

Okay, the changelog entry seems to already be in 15765, so do not add it in this PR anymore.

As you had suggested merged that PR in to this.

@anangl anangl merged commit 4bad2cd into nrfconnect:main Jun 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krish2718 krish2718 krish2718 approved these changes

@VivekUppunda VivekUppunda VivekUppunda approved these changes

@sachinthegreen sachinthegreen sachinthegreen approved these changes

@bama-nordic bama-nordic bama-nordic approved these changes

@peknis peknis peknis approved these changes

@rlubos rlubos Awaiting requested review from rlubos

@rado17 rado17 Awaiting requested review from rado17

@carlescufi carlescufi Awaiting requested review from carlescufi

@richabp richabp Awaiting requested review from richabp

@kittydepa kittydepa Awaiting requested review from kittydepa

@umapraseeda umapraseeda Awaiting requested review from umapraseeda

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
8 participants
@D-Triveni @NordicBuilder @peknis @krish2718 @bama-nordic @sachinthegreen @VivekUppunda @anangl