Support to Bluetooth RPC Host for nRF54H20 #15634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppryga-nordic
requested review from
alwa-nordic,
jori-nordic,
carlescufi,
KAGA164,
tejlmand and
nordicjm
as code owners
github-actions
bot
added
doc-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
3667023
to
b5d056c
Compare
ppryga-nordic
changed the title
ppryga-nordic
requested review from
hubertmis
and removed request for
tejlmand,
carlescufi,
alwa-nordic and
jori-nordic
hubertmis
reviewed
Jun 3, 2024
snippets/nordic-rpc-host/boards/nrf54h20dk_nrf54h20_cpurad.overlay
Outdated
Show resolved
Hide resolved
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
2 times, most recently
from
d05cc93
to
539f5f3
Compare
|
Fixed licenses and added CODEOWNERS entry for the new snippet. |
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
539f5f3
to
8295af2
Compare
hubertmis
reviewed
Jun 3, 2024
snippets/nordic-rpc-host/boards/nrf54h20dk_nrf54h20_cpurad.overlay
Outdated
Show resolved
Hide resolved
snippets/nordic-rpc-host/boards/nrf54h20dk_nrf54h20_cpurad.overlay
Outdated
Show resolved
Hide resolved
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
8295af2
to
ce2e708
Compare
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
ce2e708
to
009755a
Compare
dchat-nordic
reviewed
Jun 4, 2024
nordicjm
reviewed
Jun 4, 2024
| #include "nrf54h20dk_nrf54h20-mem-map-move.dtsi" | ||
|
|
||
| &cpurad_rw_partitions { | ||
| status = "okay"; |
Comment on lines
9
to
15
| config NRF_IPC_RADIO_RPC_HOST | ||
| bool "Enable building RPC Host for Radio domain" | ||
| help | ||
| The option enables building sample rpc_host application for Radio | ||
| domain. This sysbuild configuration option should be selected only if | ||
| an Application core application is build with CONFIG_BT_RPC_STACK | ||
| enabled. |
There was a problem hiding this comment.
why do we need yet another kconfig for the same thing?
There was a problem hiding this comment.
That was my bad, I should have added description to NRF_DEFAULT_RPC_HOST.
Anyway the config was removed. Since there is change in approach and ipc_radio application will be used instead of rpc_host part of the content in this file was extracted to sysbuild.conf and sysbuild_bt_rpc.conf.
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
009755a
to
3e6c077
Compare
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
3e6c077
to
b974b4a
Compare
dchat-nordic
approved these changes
Jun 4, 2024
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
b974b4a
to
d8eff30
Compare
|
Added nR53 support to new snippet. Fixed build issue caused by wrong snippet name in sample.yaml. |
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
d8eff30
to
f21cf4e
Compare
|
changed |
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
f21cf4e
to
5b28a82
Compare
There is experimental RPC wrapper for Bluetooth API. To make possible use of BLE samples with nRF54h20 and the RPC API there is required a settings partition for Radio core. That means current memory map has to be changed to make room for new settings partition. To make an application to use the Bluetooth rpc subsystem there is added CONFIG_BT_RPC_STACK. It enables BT RPC host client wrapper to be used instead of regular Bluetooth API. With these changes end user needs to add -S nrf-bt-rpc to west call to build a compatible BLE sample for BT RPC host. To make clean complete build for both Radio and App cores addtitional changes are required in sysbuild configuration. These will be added in follow up commits. The snippet can be also used for builds for nRF5340, though there is no need for memory map reorganization. Signed-off-by: Piotr Pryga <[email protected]>
There were no simple way to use sysbuild for building BLE samples with rpc_host running on Radio core. Add required configuration to sysbuild. Now an application can be targeted to be build with rpc_host by adding NRF_DEFAULT_RPC_HOST=y to Kconfig.sysbuild. Signed-off-by: Piotr Pryga <[email protected]>
Add possibility to build the sample application targeted to nrf54h20 with use of Bluetooth API wrapped with RPC Host client. The Radio core application in such case must be ipc_radio with enabled Bluetooth RPC host. That reqires change to sysbuild configuration of the sample application. One note, the Bluetooth RPC subsystem requires to have same Bluetooth device name on obth ends of RPC communication, so there is used FILE_SUFFIX=bt_rpc and provided sysbuild configuration files that are include when the suffix is used in build call. To build the sample with enabled Bluetooth RPC subsys use: 'west build -b nrf54h20dk/nrf54h20/cpuapp --sysbuild -p -S nordic-bt-rpc -- -DFILE_SUFFIX=bt_rpc' Signed-off-by: Piotr Pryga <[email protected]>
The former implementation of settings initialization was based on a command send by client by rpc_settings_set() function. That function was called by stetings subsustem during settings_load() execution. That together created deep execution call stack that required extended main thread stack size. To avoid the change to stack size, the implementation is changed, to send the settings load command to host if CONFIG_SETTINGS is eanbled. The command is send directly from bt_enable() function in bt_rpc_gap_client.c. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
force-pushed
the
github-rpc-host-for-nrf54h20
branch
from
5b28a82
to
e18afc4
Compare
nordicjm
approved these changes
Jun 5, 2024
|
BLE CI has a setup failure due to commit message check. It should not block the PR as long as the test job has passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility to use complete Bluetooth stack on e.g. nRF5340 network core, meaning Host and Controller run in same core. An application communicates with the stack over Bluetooth RPC subsystem that wraps Bluetooth API into RPC.
The PR adds possibility to use the same approach for samples running on nRF54H20 SOC.
To make it easy, the nordic-rcp-host snippet was added.
Also a peripheral_uart Kconfig.sysbuild was modified to make possible to select radio domain target sample application.
One additional change was done to Bluetooth RPC subsystem, handling of
settingsinitialization on remote. That change was done because former implementation required to increase main thread stack size.