Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: add thingy91x to sample.yaml #15685

Merged
merged 2 commits into from
Jun 5, 2024
Merged

treewide: add thingy91x to sample.yaml #15685

merged 2 commits into from
Jun 5, 2024

Conversation

maxd-nordic
Copy link
Contributor

This commit adds the thingy91x to samples that should be supported by launch.

@maxd-nordic maxd-nordic requested review from gregersrygg and jhn-nordic and removed request for a team June 4, 2024 08:44
@maxd-nordic maxd-nordic added this to the 2.7.0 milestone Jun 4, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 4, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 4, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@divipillai divipillai self-requested a review June 4, 2024 08:48
MarkusLassila
MarkusLassila approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@MarkusLassila MarkusLassila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLM OK

@trantanen
Copy link
Contributor

trantanen commented Jun 4, 2024 •
edited
Loading

You should get document build succeed after sample_board_rows.txt changes in PR #15225 so just rebase this PR.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

divipillai
divipillai approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@divipillai divipillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc update (minor) + release notes would be covered in a separate PR for these samples.

@shanthanordic
Copy link

CI is very RED, moving it out of NCS 2.7.0 @maxd-nordic

@shanthanordic shanthanordic removed this from the 2.7.0 milestone Jun 5, 2024
@maxd-nordic
treewide: add thingy91x to sample.yaml
c3e15f6 
This commit adds the thingy91x to samples that should
be supported by launch.

Signed-off-by: Maximilian Deubel <[email protected]>
@maxd-nordic
Copy link
Contributor Author

CI is very RED, moving it out of NCS 2.7.0 @maxd-nordic

This is a documentation PR. If CI is RED in general, it should not block this PR. @shanthanordic

@maxd-nordic maxd-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 5, 2024
@maxd-nordic maxd-nordic added this to the 2.7.0 milestone Jun 5, 2024
@divipillai
Copy link
Contributor

@shanthanordic : This PR was requested to update the "integration_platforms" field, so that the requirements table of the sample docs are update with the Thingy:91 support. https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/applications/serial_lte_modem/doc/slm_description.html#requirements

Is it okay to add a CI-disable label to this PR, considering the above? or should all the tests pass for this PR?

@jorgenmk
Copy link
Contributor

jorgenmk commented Jun 5, 2024

This PR adds some new build configurations to twister stage, so all tests should pass. The failing test here is thingy91 + carrier build, which had problems earlier this week. Perhaps a rebase will fix?

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 5, 2024
@jtguggedal
Copy link
Contributor

jtguggedal commented Jun 5, 2024 •
edited
Loading

Pushed with cherry-picked commit from #15569 that disables the problematic testcase in CI, as it's already broken.
Pushed with cherry-picked 3ce5804 from #15569 that makes the test case fit in flash.
FYI @nordic-hani

@jtguggedal jtguggedal removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 5, 2024
@nordic-hani @jtguggedal
lib: lwm2m_carrier: asset_tracker_v2: Disable assert verbose
7b28d3e 
Disable the assert verbosity to save memory.
This allows the LwM2M carrier library to still fit
for the Thingy:91 build target.

Signed-off-by: Håvard Vermeer <[email protected]>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 5, 2024
@jtguggedal jtguggedal removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 5, 2024
@jtguggedal
Copy link
Contributor

CI is very RED, moving it out of NCS 2.7.0 @maxd-nordic

@shanthanordic CI is green now, so this can be merged for the release

@rlubos rlubos merged commit 85b6366 into nrfconnect:main Jun 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusLassila MarkusLassila MarkusLassila approved these changes

@divipillai divipillai divipillai approved these changes

@trantanen trantanen trantanen approved these changes

@jhirsi jhirsi Awaiting requested review from jhirsi

@tokangas tokangas Awaiting requested review from tokangas

@rlubos rlubos Awaiting requested review from rlubos

@lemrey lemrey Awaiting requested review from lemrey

@SeppoTakalo SeppoTakalo Awaiting requested review from SeppoTakalo

@tomi-font tomi-font Awaiting requested review from tomi-font

@coderbyheart coderbyheart Awaiting requested review from coderbyheart coderbyheart is a code owner

@gregersrygg gregersrygg Awaiting requested review from gregersrygg gregersrygg is a code owner automatically assigned from nrfconnect/ncs-cia

@jhn-nordic jhn-nordic Awaiting requested review from jhn-nordic jhn-nordic is a code owner automatically assigned from nrfconnect/ncs-cia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
10 participants
@maxd-nordic @NordicBuilder @trantanen @shanthanordic @divipillai @jorgenmk @jtguggedal @MarkusLassila @rlubos @nordic-hani