Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMDN upstream part 8: Fast Pair Integration guide update with the FMDN content #15688

Merged

Conversation

kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Jun 4, 2024

Follow-up upstreaming activity for the documentation content after the following PR (DULT documentation):

#15643

@kapi-no kapi-no added this to the 2.7.0 milestone Jun 4, 2024
@kapi-no kapi-no requested a review from carlescufi as a code owner June 4, 2024 08:54
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jun 4, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 4, 2024

Test specification

CI/Jenkins/NRF

  • Skipped

CI/Jenkins/integration

  • Skipped

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

FMDN extension
==============

The FMDN extension leverages the Find My Device network, which is a crowdsourced network consisting of millions of Android devices that use Bluetooth® LE to detect missing devices and report their approximate locations back to their owners.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The FMDN extension leverages the Find My Device network, which is a crowdsourced network consisting of millions of Android devices that use Bluetooth® LE to detect missing devices and report their approximate locations back to their owners.
The FMDN extension leverages the Find My Device network, which is a crowdsourced network consisting of millions of Android devices that use Bluetooth LE to detect missing devices and report their approximate locations back to their owners.

Trademark already mentioned in the docs.

Comment on lines +260 to +262
* The :c:func:`bt_fast_pair_fmdn_info_cb_register` function (optional)
* The :c:func:`bt_fast_pair_fmdn_ring_cb_register` function (mandatory with the Kconfig configuration for at least one ringing component)
* The :c:func:`bt_fast_pair_fmdn_read_mode_cb_register` function (optional)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions don't link. Is the reason that the related header files has not yet been merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on Teams. We plan to merge the FMDN documentation in the follow-up PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extended the Fast Pair user guide to cover the Find My Device Network
extension.

Ref: NCSDK-20552

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no force-pushed the fmdn_upstream_part8_fp_ug_fdmn_update branch from 1ac8007 to 1295904 Compare June 5, 2024 07:07
@kapi-no kapi-no requested a review from divipillai June 5, 2024 07:07
@kapi-no kapi-no removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 5, 2024
@rlubos rlubos merged commit 0567e59 into nrfconnect:main Jun 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc only doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants