Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: matter: light bulb psub merged with mem profiling #15696

Merged
merged 1 commit into from
Jun 5, 2024
Merged

samples: matter: light bulb psub merged with mem profiling #15696

merged 1 commit into from
Jun 5, 2024

Conversation

HubertHugo
Copy link
Contributor

Sample light bulb with psub merged with sample with mem profiling.

@HubertHugo HubertHugo requested a review from a team as a code owner June 4, 2024 12:04
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 4, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 4, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@HubertHugo HubertHugo force-pushed the light_psub_and_memprof_merge branch from 6343474 to 09bf073 Compare June 4, 2024 12:19
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@HubertHugo HubertHugo force-pushed the light_psub_and_memprof_merge branch from 09bf073 to 3a9cee9 Compare June 4, 2024 13:56
@HubertHugo HubertHugo requested review from tejlmand and a team as code owners June 4, 2024 13:56
@HubertHugo
samples: matter: light bulb psub merged with mem profiling
00fce2b 
Sample light bulb with psub merged with sample with mem profiling.

Signed-off-by: Hubert Górski <[email protected]>
@HubertHugo HubertHugo force-pushed the light_psub_and_memprof_merge branch from 3a9cee9 to 00fce2b Compare June 4, 2024 14:09
@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug_nrf54h20[nrf54h20dk/nrf54h20/cpuapp]: RAM size increased by 27407[B] in comparison to the main[2bfa3f3] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_nrf54h20[nrf54h20dk/nrf54h20/cpuapp]: ROM size increased by 29632[B] in comparison to the main[2bfa3f3] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease_nrf54h20[nrf54h20dk/nrf54h20/cpuapp]: RAM size increased by 27375[B] in comparison to the main[2bfa3f3] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease_nrf54h20[nrf54h20dk/nrf54h20/cpuapp]: ROM size increased by 21480[B] in comparison to the main[2bfa3f3] branch. - link (cc: @MarekPieta)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-15696/4)

doublemis1
doublemis1 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@doublemis1 doublemis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rlubos rlubos merged commit 76d0fd6 into nrfconnect:main Jun 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@doublemis1 doublemis1 doublemis1 approved these changes

@tejlmand tejlmand Awaiting requested review from tejlmand

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HubertHugo @NordicBuilder @doublemis1 @kkasperczyk-no @rlubos