Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: thingy91x: Fix external flash issue with mcuboot #15733

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

maxd-nordic
Copy link
Contributor

This patch fixes the issue that prevented MCUboot
to work at all on the Thingy:91 X.

This patch fixes the issue that prevented MCUboot
to work at all on the Thingy:91 X.

Signed-off-by: Maximilian Deubel <[email protected]>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 5, 2024
@NordicBuilder
Copy link
Contributor

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@maxd-nordic maxd-nordic added this to the 2.7.0 milestone Jun 5, 2024
@maxd-nordic maxd-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 5, 2024
@balaji-nordic balaji-nordic self-requested a review June 5, 2024 08:56
@maxd-nordic maxd-nordic added the bugfix Fixes a known bug label Jun 5, 2024
@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug_mcuboot_smp.nrf52840dk[nrf52840dk/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease_fast_pair.keyboard[nrf52kbd/nrf52832]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840dk/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840gmouse/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_nrf21540ek[nrf52840dk/nrf52840]: ROM size increased by 1256[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_wwcb[nrf52840dk/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_keyboard.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease.nrf52kbd[nrf52kbd/nrf52832]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52840gmouse/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52kbd/nrf52832]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_keyboard[nrf52840dk/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_mcuboot_qspi[nrf52840dk/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.usb_next[nrf52840gmouse/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_mcuboot_smp.nrf52840gmouse[nrf52840gmouse/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_fast_pair.gmouse[nrf52840gmouse/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebugwithshell[nrf52840dk/nrf52840]: ROM size increased by 1216[B] in comparison to the main[f0ca215] branch. - link (cc: @MarekPieta)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-15733/1)

@rlubos rlubos merged commit bc4f0fd into nrfconnect:main Jun 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants