Bluetooth: Add hci_vs_sdc.h which expose wrappers VS HCI commands #15798
+765
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rugeGerritsen
requested review from
alwa-nordic,
jori-nordic,
carlescufi and
KAGA164
as code owners
github-actions
bot
added
the
changelog-entry-required
rugeGerritsen
force-pushed
the
expose-hci-wrappers
branch
from
159dcf4
to
5d2e92a
Compare
|
in a follow-up, should we update the content of host_extensions.c? |
Yes, and also other places where applications and samples are now building and sending these HCI commands manually |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
rugeGerritsen
force-pushed
the
expose-hci-wrappers
branch
from
5d2e92a
to
cab774a
Compare
alwa-nordic
requested changes
Jun 7, 2024
rugeGerritsen
force-pushed
the
expose-hci-wrappers
branch
3 times, most recently
from
3b8bedd
to
6f38cdc
Compare
alwa-nordic
approved these changes
Jun 7, 2024
rugeGerritsen
force-pushed
the
expose-hci-wrappers
branch
2 times, most recently
from
5bde48a
to
f2416b8
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
theob-pro
approved these changes
Jun 10, 2024
The SDC provides vendor specific Bluetooth functionality through vendor specific HCI commands. The APIs added in this commit handles: - Building the VS HCI commands - Sending the VS HCI command to the controller. This works both when the controller is on the same core, or if the controller is separated from the host by another HCI layer. - Return parameters This removes the need for boilerplate code in applications. Some of the vendor specific APIs take in handles. Those can be obtained from host types using the APIs defined in `zephyr/bluetooth/hci.h`. The API documentation is referring to the HCI command documentation to avoid duplication. Signed-off-by: Rubin Gerritsen <[email protected]>
rugeGerritsen
force-pushed
the
expose-hci-wrappers
branch
from
f2416b8
to
60a3a86
Compare
rugeGerritsen
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDC provides vendor specific Bluetooth functionality through vendor specific HCI commands.
The APIs added in this commit handles:
This removes the need for boilerplate code in applications.
Some of the vendor specific APIs take in handles.
Those can be obtained from host types using the APIs defined in
zephyr/bluetooth/hci.h.The API documentation is referring to the HCI command documentation to avoid duplication.