Don't review #17367
Closed
Don't review #17367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert error callback to include general status notifications from the FOTA library as well as error events. This gives the application the opportunity to block network related operations during FOTA updates. Add image type to reboot function to allow the application to reinitialize the modem after a firmware update. Its not nessecary to reboot the device after modem FOTA. Signed-off-by: Simen S. Røstad <[email protected]>
- Use nrf modem library CFUN callback to prevent modem info calls in offline and powered off states. This is needed instead of fetching the func mode due to the modem being shutdown when a lte handler notification is received. - Ease up on the logging when modem info API are called. Its expected that they fail in certain scenarios, and logging an error in those instances is not necessary. Signed-off-by: Simen S. Røstad <[email protected]>
Add option, CONFIG_NRF_CLOUD_COAP_DISCONNECT_ON_FAILED_REQUEST, that disconnects the CoAP client on a failed request. Disabled by default. Signed-off-by: Simen S. Røstad <[email protected]>
lte_lc_edrx_req() will be run directly in lte_lc_edrx_on_modem_cfun() when power off is issued. Earlier it was submitted to a work queue and run in lte_lc_work_q. Work queue was originally added because we wanted to avoid sending AT commands in the callback. However, when modem is powered off, we are not expecting AT notifications that could cause an assertion or missing notification. This was added in PR nrfconnect#15203 Jira: NCSIDB-1347 Signed-off-by: Tommi Rantanen <[email protected]>
nrf_modem_lib uses 'AT+CFUN=0' in nrf_modem_lib_shutdown() if the mode is not already '0'. So doing this also in lte_lc is unnecessary. Signed-off-by: Tommi Rantanen <[email protected]>
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:more detailsGithub labels
List of changed files detected by CI (0)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't review