-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_security: Move PSA_WANT symbols from Zephyr to nrf_security #17724
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 3d032b93f2ee10e39f5430e6678c69b3a96551cd more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (27)
Outputs:ToolchainVersion: 3dd8985b56 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
same question goes for this commit: nrfconnect/sdk-zephyr@0892bad why are we having this as a noup instead of keeping it downstream ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (minus removal of CFB and OFB which we don't want to continue supporting)
bb72693
to
9115b4b
Compare
a747da4
to
c6fd0f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending correct SHA and green CI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice little cleanup. (Two tiny remarks, do what you want with them.)
I'm thinking, regarding CFB and OFB removal, maybe this also requires some update to the following files?
doc/nrf/libraries/security/nrf_security/doc/driver_config.rst
subsys/nrf_security/src/drivers/Kconfig.psa_accel
subsys/nrf_security/include/psa/core_unsupported_ciphers_check.h
c6fd0f5
to
4cb6232
Compare
0753b00
to
d297ce2
Compare
4ccb222
to
9c2feee
Compare
9c2feee
to
4cd037c
Compare
@nrfconnect/ncs-co-build-system @nrfconnect/ncs-code-owners @nrfconnect/ncs-aegir-doc please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just removed from the rst file, so it's all good from the doc perspective, except from a missing changelog entry.
Added something there. |
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
The Nordic only PSA_WANTs are moved from Zephyr to nrf_security to reduce the noup commits in sdk-zephyr. Signed-off-by: Georgios Vasilakis <[email protected]>
To avoid noup commits in Zephyr. Signed-off-by: Georgios Vasilakis <[email protected]>
Move some PSA_WANTs from the drivers Kconfig in nrf_security to the Kconfig file which contains the rest of the PSA_WANT configurations. During the upmerge support for OFB and CFB modes of AES was removed so here we remove the relevant code in the drivers as well. Signed-off-by: Georgios Vasilakis <[email protected]>
Add a changelog entry to make it visible that the ciphers OFB and CFB from PSA are no longer supported. Signed-off-by: Georgios Vasilakis <[email protected]>
33c6feb
to
3d032b9
Compare
The Nordic only PSA_WANT symbols make more sense to be placed here instead of adding a noup commit in Zephyr