Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: mss: Fix Wi-Fi connectivity #17951

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

glarsennordic
Copy link
Contributor

Two commits to fix Wi-Fi connectivity for MSS after upmerge.

One of these commits will also benefit any other users of conn_mgr

@glarsennordic glarsennordic requested review from a team as code owners October 17, 2024 00:55
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 17, 2024
@glarsennordic
Copy link
Contributor Author

This is a redo of #17794

I want to leave that one in its original state since it is referenced right now by internal tickets

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 17, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 243b912b1e68e20958c3aa346a84dd06ff1e00db

more details

sdk-nrf:

PR head: 243b912b1e68e20958c3aa346a84dd06ff1e00db
merge base: 5793075b68214f2f4794c7ea92c49d6c79c5ac2f
target head (main): 6f5194b6cac97d8bea615bcc0629fd43dfc679d8
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7)
samples
│  ├── cellular
│  │  ├── nrf_cloud_multi_service
│  │  │  ├── overlay_coap.conf
│  │  │  ├── overlay_nrf700x_wifi_coap_no_lte.conf
│  │  │  │ overlay_nrf700x_wifi_mqtt_no_lte.conf
│  ├── net
│  │  ├── mqtt
│  │  │  │ overlay-tls-nrf70.conf
subsys
│  ├── net
│  │  ├── l2_wifi_if_conn
│  │  │  ├── Kconfig
│  │  │  │ l2_wifi_conn.c
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── src
│  │  │  │  │  │ nrf_cloud_info.c

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 301
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@glarsennordic glarsennordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 17, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@glarsennordic glarsennordic requested a review from a team October 17, 2024 18:56
@plskeggs plskeggs added this to the 2.8.0 milestone Oct 17, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 17, 2024
@glarsennordic glarsennordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 18, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 18, 2024
@glarsennordic
Copy link
Contributor Author

Red CI here appears to be caused by net/mqtt sample, and is totally unrelated to this PR

@glarsennordic glarsennordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 21, 2024
@nordic-piks
Copy link
Contributor

Red CI here appears to be caused by net/mqtt sample, and is totally unrelated to this PR

CI - twister - at main is green - so either your PR is related to that fail or it needs rebase. CI should be green.

Copy link
Contributor

@nordic-piks nordic-piks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase is needed to get green CI.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 22, 2024
@glarsennordic
Copy link
Contributor Author

My bad, the twister failure was actually related to my changes!

@glarsennordic glarsennordic dismissed nordic-piks’s stale review October 22, 2024 20:13

CI is green now, dismissing so that a different merge reviewer can merge if they are online

Fix missing conn_mgr binding for Wi-Fi/nrf700x.

Signed-off-by: Georges Oates_Larsen <[email protected]>
Various tweaks to fix Multi Service
Sample Wi-Fi connectivity builds.

IRIS-9847

Signed-off-by: Georges Oates_Larsen <[email protected]>
A bugfix for PGPS on certain CoAP configurations, and a tweak
to nrf_cloud library info logs.

Signed-off-by: Georges Oates_Larsen <[email protected]>
@nordic-piks nordic-piks removed their request for review October 23, 2024 05:48
@nordicjm nordicjm merged commit 214da5d into nrfconnect:main Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants