samples: nfc: writable_ndef_msg: Migrate from NVS to ZMS for nRF54 #18043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 6a4d39d89a2cd45daf44eea63b3fd45bbae6e35d more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: 3dd8985b56 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
rghaddab
reviewed
Oct 21, 2024
| #define NVS_SECTOR_SIZE (DT_PROP(DT_CHOSEN(zephyr_flash), erase_block_size)) | ||
| #define NVS_SECTOR_COUNT 2 | ||
| #define SECTOR_SIZE (DT_PROP(DT_CHOSEN(zephyr_flash), erase_block_size)) | ||
| #define SECTOR_COUNT 2 |
There was a problem hiding this comment.
Just to check, erase_block_size in reality doesn't make sense for ZMS to choose the sector_size. And its value is 4K I guess for most of the boards.
Did you make the calculations to verify that 4000 bytes (4096 - header) are enough for your application ?
The recommended size should be at least double the size that you need for your data
There was a problem hiding this comment.
The sample stores a maximum of 1024 bytes.
doki-nordic
approved these changes
Oct 22, 2024
maje-emb
force-pushed
the
nfc_zms
branch
3 times, most recently
from
7c1dc81
to
472df58
Compare
These changes introduce the use of the ZMS file system instead of NVS for the nRF54 series. Ref: NCSDK-29636 Signed-off-by: Marcin Jelinski <[email protected]>
rghaddab
approved these changes
Oct 23, 2024
miha-nordic
approved these changes
Oct 23, 2024
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce the use of the ZMS file system instead of NVS for the nRF54 series.
Ref: NCSDK-29636