Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: bootloader_partitioning: add info about VSC #18045

Conversation

greg-fer
Copy link
Contributor

Edited the structure of bootloader_partitioning page to mention memory reports of the VSC extension alongside partition_manager_report. Fixed some formatting and structure issues and typos. VSC-2712.

@greg-fer greg-fer added CI-disable Disable CI for this PR doc only labels Oct 21, 2024
@greg-fer greg-fer added this to the 2.8.0 milestone Oct 21, 2024
@greg-fer greg-fer requested review from a team as code owners October 21, 2024 12:32
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 21, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 21, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

@greg-fer greg-fer removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 21, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

.. group-tab:: nRF Connect for VS Code

Use the extension's `Memory report`_ feature, which shows the size and percentage of memory that each symbol uses on your device for RAM, ROM, and partitions.
Click the :guilabel:`Memory report` button in the :guilabel:`Actions View` to generate the report.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to be even more specific, we can instruct users to then choose the "partitioning" tab.

Use the Partition Manager's :ref:`pm_partition_reports` feature.
Run the following command:

.. code-block: console
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Cant see command.

******************

After you enable the Partition Manager, it will :ref:`start generating <pm_build_system>` the :file:`partitions.yml` file in the build folder directory.
In this file, you will detailed information about the memory layout used for the build.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this file, you will detailed information about the memory layout used for the build.
In this file, you will see detailed information about the memory layout used for the build.

Click the :guilabel:`Memory report` button in the :guilabel:`Actions View` to generate the report.

Alternatively, you can also use the `Memory Explorer <How to work with the Memory Explorer_>`_ feature of the extension's nRF Debug to check memory sections for the partitions.
This feature requires `enabling debugging in the build configuration <How to debug>`_ and providing the partition addresses manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link's not working

Suggested change
This feature requires `enabling debugging in the build configuration <How to debug>`_ and providing the partition addresses manually.
This feature requires `enabling debugging in the build configuration <How to debug_>`_ and providing the partition addresses manually.

Edited the structure of bootloader_partitioning page to mention
memory reports of the VSC extension alongside partition_manager_report.
Fixed some formatting and structure issues and typos.
VSC-2712.

Signed-off-by: Grzegorz Ferenc <[email protected]>
@greg-fer greg-fer force-pushed the doc_mention_vsc_memory_report_for_flash_partitions branch from c3a9d9e to aa33cad Compare October 22, 2024 08:20
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 22, 2024
@greg-fer greg-fer added the DNM label Oct 22, 2024
@greg-fer greg-fer changed the title doc: bootloader_partitioning: add info about VSC [ON HOLD] doc: bootloader_partitioning: add info about VSC Oct 22, 2024
@greg-fer
Copy link
Contributor Author

@FilipZajdel and @hellesvik-nordic discovered inconsistencies in the extension behavior that will be fixed for the next release. This PR will be merged once those fixes are live.

@greg-fer
Copy link
Contributor Author

Fixes merged by @AliceMadama . Awaiting the release of the extension to ask for merge for this PR.

@greg-fer greg-fer added backport v2.8-branch auto-create a PR with same commits to v2.8-branch and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM labels Nov 6, 2024
@greg-fer greg-fer changed the title [ON HOLD] doc: bootloader_partitioning: add info about VSC doc: bootloader_partitioning: add info about VSC Nov 6, 2024
@rlubos
Copy link
Contributor

rlubos commented Nov 6, 2024

@nrfconnect/ncs-aurora-doc Ping, please review

@rlubos rlubos merged commit a3a1f46 into nrfconnect:main Nov 6, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.8-branch auto-create a PR with same commits to v2.8-branch CI-disable Disable CI for this PR doc only doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants