samples: Add console suspend in system_off #18083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 651df30a1af51ca4c2ee610a0d2fcabca68423c5 more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
dchat-nordic
approved these changes
Oct 22, 2024
grochu
reviewed
Oct 22, 2024
Comment on lines
38
to
37
| CONFIG_ASSERT=n | ||
| CONFIG_BT_ASSERT=n | ||
| CONFIG_ASSERT_VERBOSE=n |
There was a problem hiding this comment.
Should we consider disabling CONFIG_NCS_SAMPLES_DEFAULTS?
There was a problem hiding this comment.
Why you are disabling asserts?
There was a problem hiding this comment.
Should we consider disabling
CONFIG_NCS_SAMPLES_DEFAULTS?
Yes, I think we should disable CONFIG_NCS_SAMPLES_DEFAULTS.
There was a problem hiding this comment.
Why you are disabling asserts?
I disabled asserts to reduce code and power consumption.
maje-emb
force-pushed
the
sys_poweroff
branch
from
a690a71
to
37781fe
Compare
Added console suspend before `sys_poweroff` to reduce power usage. Ref: NCSDK-29688 Signed-off-by: Marcin Jelinski <[email protected]>
Added console suspend before `sys_poweroff` to reduce power usage. Ref: NCSDK-29688 Signed-off-by: Marcin Jelinski <[email protected]>
maje-emb
force-pushed
the
sys_poweroff
branch
from
37781fe
to
651df30
Compare
doki-nordic
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added console suspend before
sys_poweroffto reduce power usage inbluetooth: peripheral_power_profilingandnfc: system_offsamples.