Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: Add support for LE Power Class 1 Feature #18084

Merged

Conversation

bugo-nordic
Copy link
Contributor

Enables the local support bit for the LE Power Class 1 Feature

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest labels Oct 22, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/[email protected] nrfconnect/sdk-nrfxlib@226084d (v2.5.0-NCSDK-29842-branch) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 124ea24002c72d2d0c9948a879ab71460bb0dde5
nrfxlib: PR head: 226084d98b6a61a0026c80947eb4476cb602a914

more details

sdk-nrf:

PR head: 124ea24002c72d2d0c9948a879ab71460bb0dde5
merge base: 1fae141fc6713dd331b797fc96c90dc84552242d
target head (v2.5.0-NCSDK-29842-branch): ade425e08dc3fca9527a6ee9d637e1a81efae232
Diff

nrfxlib:

PR head: 226084d98b6a61a0026c80947eb4476cb602a914
merge base: 78cc07ed7c9f168c3d6316db5af969ac5f7c977a
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (12)
nrfxlib
│  ├── softdevice_controller
│  │  ├── CHANGELOG.rst
│  │  ├── lib
│  │  │  ├── cortex-m4
│  │  │  │  ├── hard-float
│  │  │  │  │  ├── libsoftdevice_controller_central.a
│  │  │  │  │  ├── libsoftdevice_controller_multirole.a
│  │  │  │  │  │ libsoftdevice_controller_peripheral.a
│  │  │  │  ├── soft-float
│  │  │  │  │  ├── libsoftdevice_controller_central.a
│  │  │  │  │  ├── libsoftdevice_controller_multirole.a
│  │  │  │  │  │ libsoftdevice_controller_peripheral.a
│  │  │  │  ├── softfp-float
│  │  │  │  │  ├── libsoftdevice_controller_central.a
│  │  │  │  │  ├── libsoftdevice_controller_multirole.a
│  │  │  │  │  │ libsoftdevice_controller_peripheral.a
subsys
│  ├── bluetooth
│  │  ├── controller
│  │  │  │ hci_internal.c
west.yml

Outputs:

Toolchain

Version: 7795df4459
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7795df4459_17a7fb6924

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
  • ❌ Integration tests
    • ❌ desktop52_verification
    • ❌ test_ble_nrf_config
    • ❌ test-fw-nrfconnect-ble_mesh
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-rs
    • ❌ test-fw-nrfconnect-fem
    • ❌ test-fw-nrfconnect-zigbee
    • ❌ test-sdk-find-my
    • ❌ test-sdk-sidewalk
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@shanthanordic shanthanordic requested review from guwa and removed request for tejlmand October 22, 2024 11:16
@shanthanordic
Copy link

This PR should not be merged without @guwa approval

Enables the local support bit for the LE Power Class
1 Feature

Signed-off-by: Burak Gorduk <[email protected]>
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 22, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_mesh X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem-legacy X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-zigbee X
test-sdk-find-my X
test-sdk-homekit X
test-sdk-sidewalk X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@guwa guwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is only one single bit change, which is not used in the stack. I accept all test coverage we have so far (twister build + SDC conformance test).

This PR can be merged to the release branch now.

@carlescufi carlescufi merged commit da5a682 into nrfconnect:v2.5.0-NCSDK-29842-branch Oct 23, 2024
15 of 24 checks passed
@bugo-nordic bugo-nordic deleted the v2.5-pc1-branch branch November 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-nrfxlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants