-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: controller: option to defer unknown VS commands #18112
Conversation
Add a Kconfig option to enable deferring the handling of unknown vendor specific commands to the application, instead of unconditionally dropping them. Signed-off-by: Jordan Yates <[email protected]>
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 60b134a2e633c41f6b8d48df66eddf4c02759361 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: 3dd8985b56 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the usecase can already be fulfilled with the existing hci_internal_user_cmd_handler_register()
So it is, although the |
Add a Kconfig option to enable deferring the handling of unknown vendor specific commands to the application, instead of unconditionally dropping them.
The expected use case for this option is for re-using the already present HCI link between two separate microcontrollers (e.g. nRF91 + nRF52) as a communications channel. The obvious way to enable this is through a vendor specific command, but this requires the HCI shim to not unconditionally drop commands it does not know about.
An alternate implementation option is to register a callback function with a dedicated function (
sdc_register_default_vs_handler
or similar), instead of hardcoding the expected function name. The current approach does have precedence in the LTE modem fault handling code however.Changelog will be added once implementation is confirmed