Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc improvement: updates to the Using companion components page #18142

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

divipillai
Copy link
Contributor

updates to the Using companion components page

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 23, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 23, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@divipillai divipillai added CI-disable Disable CI for this PR and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 23, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 23, 2024
@divipillai divipillai removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 23, 2024
@divipillai divipillai added this to the 2.8.0 milestone Oct 24, 2024
@divipillai divipillai changed the title doc: updates to the Using companion components page doc improvement: updates to the Using companion components page Oct 24, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 24, 2024
@divipillai divipillai marked this pull request as ready for review October 24, 2024 15:33
@divipillai divipillai requested review from FrancescoSer and a team as code owners October 24, 2024 15:33
@divipillai divipillai removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 24, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 28, 2024
@divipillai divipillai added backport v2.8-branch auto-create a PR with same commits to v2.8-branch and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 28, 2024
doc/nrf/app_dev/companion_components.rst Outdated Show resolved Hide resolved
@pdunaj
Copy link
Contributor

pdunaj commented Oct 28, 2024

FYI @PaalKastnes , @faune

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 28, 2024
@divipillai divipillai removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 28, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 28, 2024
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a mention in the changelog for this update.

updates to the Using companion components page

Signed-off-by: divya pillai <[email protected]>
@divipillai divipillai removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 29, 2024
@rlubos rlubos merged commit 5f04936 into nrfconnect:main Oct 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.8-branch auto-create a PR with same commits to v2.8-branch CI-disable Disable CI for this PR doc only doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants