Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: cellular: nrf_cloud_rest_fota: add smp fota for nrf9160dk #18145

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

jayteemo
Copy link
Contributor

Add the option to enable SMP FOTA on the nRF9160DK.
IRIS-9481

@jayteemo jayteemo added this to the 2.8.0 milestone Oct 23, 2024
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Oct 23, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 23, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: a56457b6737b48206b00ee554159d6999398d75e

more details

sdk-nrf:

PR head: a56457b6737b48206b00ee554159d6999398d75e
merge base: 4c75e6d248ecb25619ad17891af7d19718ab4574
target head (main): 4c75e6d248ecb25619ad17891af7d19718ab4574
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7)
samples
│  ├── cellular
│  │  ├── nrf_cloud_rest_fota
│  │  │  ├── CMakeLists.txt
│  │  │  ├── README.rst
│  │  │  ├── nrf9160dk_mcumgr_client_uart2.overlay
│  │  │  ├── overlay_smp_fota.conf
│  │  │  ├── src
│  │  │  │  ├── main.c
│  │  │  │  ├── smp_reset.c
│  │  │  │  │ smp_reset.h

Outputs:

Toolchain

Version: add720b6d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:add720b6d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 203
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ⚠️ test-fw-nrfconnect-fw-update
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@jayteemo jayteemo marked this pull request as ready for review October 23, 2024 20:14
@jayteemo jayteemo requested review from a team as code owners October 23, 2024 20:14
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

samples/cellular/nrf_cloud_rest_fota/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_rest_fota/README.rst Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_rest_fota/README.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions before approving (and a nit.)

@rlubos rlubos added the backport v2.8-branch auto-create a PR with same commits to v2.8-branch label Oct 25, 2024
@rlubos
Copy link
Contributor

rlubos commented Oct 25, 2024

@jayteemo We've missed RC1, but this could still go in, just need to align the PR a bit. Please drop release notes change, and post a comment in aggregate PR #18192 instead,

Add the option to enable SMP FOTA on the nRF9160DK.
IRIS-9481

Signed-off-by: Justin Morton <[email protected]>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 25, 2024
@jayteemo
Copy link
Contributor Author

@rlubos thanks, done

@rlubos rlubos merged commit a009abe into nrfconnect:main Oct 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.8-branch auto-create a PR with same commits to v2.8-branch changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants