Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v2.8-branch] Nrfx 6388 assembly mgmt west build #18221

Merged
merged 2 commits into from
Oct 25, 2024
Merged

[Backport v2.8-branch] Nrfx 6388 assembly mgmt west build #18221

merged 2 commits into from
Oct 25, 2024

Conversation

NordicBuilder
Copy link
Contributor

Backport b24793a~2..b24793a from #18018.

@magp-nordic @github-actions
cmake: add two new targets for SDP
ad3b09c 
Add two new targets regarding ASM code for SDP: asm_check
that checks if ASM file has changed, and asm_update that
updates ASM files in source directory with the new generated.

Signed-off-by: Magdalena Pastula <[email protected]>
(cherry picked from commit 2fca659)
@magp-nordic @github-actions
appplications: sdp: gpio: add asm_check to flpr_egpio
1cf38b3 
Add asm_check target as a depency for flpr_egpio application.
This will generate new ASM file for every source file in
hrt folder and check if the new ones are the same as the
one saved in git. For every file that differs a warning
is printed.

By making asm_check a dependency of flpr_egpio application
asm_check will be run both for sysbuild application including
eGPIO and for stand-alone SDP application before the main
build starts.

Signed-off-by: Magdalena Pastula <[email protected]>
(cherry picked from commit b24793a)
@NordicBuilder NordicBuilder requested a review from a team as a code owner October 25, 2024 13:40
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 25, 2024
@NordicBuilder
Copy link
Contributor Author

NordicBuilder commented Oct 25, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 1cf38b3194aac819ab66098bc409c545c9395d63

more details

sdk-nrf:

PR head: 1cf38b3194aac819ab66098bc409c545c9395d63
merge base: 08c662a0063568507d158cefd24bfa248bad9e43
target head (v2.8-branch): 08c662a0063568507d158cefd24bfa248bad9e43
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4) 
applications
│  ├── sdp
│  │  ├── gpio
│  │  │  │ CMakeLists.txt
cmake
│  ├── sdp.cmake
│  ├── sdp_asm_check.cmake
│  │ sdp_asm_install.cmake

Outputs:

Toolchain

Version: add720b6d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:add720b6d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ doc-internal
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-proprietary_esb
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-sidewalk
    • ✅ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor Author

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@rlubos rlubos merged commit 450a303 into v2.8-branch Oct 25, 2024
15 checks passed
@rlubos rlubos deleted the backport-18018-to-v2.8-branch branch October 30, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlubos rlubos rlubos approved these changes

Assignees
No one assigned
Labels
Backport changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NordicBuilder @rlubos @magp-nordic