Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: bluetooth: fast_pair: locator_tag: Set RSA sig type for DKs #18651

Merged

Conversation

mkapala-nordic
Copy link
Contributor

Set signature type to RSA for DKs.

Jira: NCSDK-29943

Set signature type to RSA for DKs.

Jira: NCSDK-29943

Signed-off-by: Mateusz Kapala <[email protected]>
@mkapala-nordic mkapala-nordic added DNM backport v2.8-branch auto-create a PR with same commits to v2.8-branch labels Nov 6, 2024
@mkapala-nordic mkapala-nordic added this to the 2.8.0 milestone Nov 6, 2024
@mkapala-nordic mkapala-nordic requested a review from a team as a code owner November 6, 2024 13:01
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 6, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 6, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 94672d0a3e9e135a7f25641e27a13942516ed295

more details

sdk-nrf:

PR head: 94672d0a3e9e135a7f25641e27a13942516ed295
merge base: 5321f8514a9cfaa82280a4c716732e2f0713cd98
target head (main): d11c5181de995c3ee5ba73dc3da37558dc05b234
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
samples
│  ├── bluetooth
│  │  ├── fast_pair
│  │  │  ├── locator_tag
│  │  │  │  ├── sysbuild
│  │  │  │  │  ├── configuration
│  │  │  │  │  │  ├── nrf52833dk_nrf52833
│  │  │  │  │  │  │  │ sysbuild_release.conf
│  │  │  │  │  │  ├── nrf52840dk_nrf52840
│  │  │  │  │  │  │  │ sysbuild.conf
│  │  │  │  │  │  ├── nrf52dk_nrf52832
│  │  │  │  │  │  │  │ sysbuild_release.conf
│  │  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp
│  │  │  │  │  │  │  │ sysbuild.conf
│  │  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp_ns
│  │  │  │  │  │  │  │ sysbuild.conf
│  │  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp
│  │  │  │  │  │  │  │ sysbuild.conf

Outputs:

Toolchain

Version: 6d50eb01ac
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6d50eb01ac_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 431
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_samples
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@mkapala-nordic mkapala-nordic removed DNM changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 7, 2024
@nordicjm nordicjm merged commit 78f806d into nrfconnect:main Nov 7, 2024
16 of 19 checks passed
@nordicjm
Copy link
Contributor

nordicjm commented Nov 7, 2024

Just wondering why you would force rsa for nrf52840 and nrf5340 when it's slower and much larger than hardware accelerated ecdsa-p256?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.8-branch auto-create a PR with same commits to v2.8-branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants