Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: tfm: Do not fprotect MCUboot for nRF54L15 #18660

Conversation

hellesvik-nordic
Copy link
Contributor

@hellesvik-nordic hellesvik-nordic commented Nov 6, 2024

Not yet supported, so disabling it in this sample for now.

@hellesvik-nordic hellesvik-nordic requested a review from a team as a code owner November 6, 2024 13:44
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 6, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 6, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: d94554f13434301f4c62224162d25467bb30ef8e

more details

sdk-nrf:

PR head: d94554f13434301f4c62224162d25467bb30ef8e
merge base: e2c83bd959a28176343ec9fac65daad3b4afc6db
target head (main): c667bd1969e65dc6261f310947b92cef06bfab00
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
samples
│  ├── tfm
│  │  ├── tfm_psa_template
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf

Outputs:

Toolchain

Version: b44b7a08c9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b44b7a08c9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 124
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-tfm
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@tomi-font tomi-font removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 6, 2024
@hellesvik-nordic
Copy link
Contributor Author

Or, more exact would be that FPROTECT is not supported in MCUboot for nRF54L15 yet, I realize. Ref https://github.com/nrfconnect/sdk-mcuboot/blob/main/boot/zephyr/boards/nrf54l15dk_nrf54l15_cpuapp.conf#L10-L11

@tomi-font
Copy link
Contributor

Or, more exact would be that FPROTECT is not supported in MCUboot for nRF54L15 yet, I realize. Ref https://github.com/nrfconnect/sdk-mcuboot/blob/main/boot/zephyr/boards/nrf54l15dk_nrf54l15_cpuapp.conf#L10-L11

Update the commit message/comment?

Not yet supported.

Signed-off-by: Sigurd Hellesvik <[email protected]>
@hellesvik-nordic hellesvik-nordic force-pushed the tfm_psa_template_sample_mcuboot_fprotect_54l branch from 48f1008 to d94554f Compare November 6, 2024 14:17
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 6, 2024
Copy link
Contributor

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellesvik-nordic
Copy link
Contributor Author

Learned that it is supported now after all. Ref #17774. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants