Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: services: ras: Implement Ranging Responder role of RAS #18750

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexstanoev-nordic
Copy link
Contributor

Implement the ranging responder (RRSP) server role of the Ranging Service draft specification.
This allows a ranging requestor (RREQ) to retrieve channel sounding ranging data from the local device.

This implementation contains support for all mandatory features, as well as using notifications for data transfer.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 7, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 7, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ❌ Toolchain
  • ❌ Build twister
  • ❌ Integration tests

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

help
The number of ranging procedures that can be stored inside RRSP.

config BT_RAS_RRSP_MAX_SUBEVENTS_PER_PROCEDURE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propose replacing BT_RAS_RRSP_MAX_STEPS_PER_PROCEDURE and BT_RAS_RRSP_MAX_STEPS_PER_PROCEDURE with:

  • BT_RAS_RRSP_MAX_ANTENNA_PATHS (range 1 4 default 4)
  • BT_RAS_RRSP_MODE_3_SUPPORTED (just yes/no, default yes)

then the only thing these configs do is change the value of BT_RAS_MAX_STEP_DATA_LEN.

We should also make sure there's some kind of warning in the case where the controller generates more data than expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised these configs are relevant for both RREQ and RRSP, so I reordered the Kconfig menus in the last commit as well.

Implement the ranging responder (RRSP) server role of the
Ranging Service draft specification.
This allows a ranging requestor (RREQ) to retrieve channel sounding
ranging data from the local device.

This implementation contains support for all mandatory features,
as well as using notifications for data transfer.

Signed-off-by: Aleksandar Stanoev <[email protected]>
Enables defining settings common for RREQ and RRSP.
Groups RREQ and RRSP under a common Ranging Service menu.

Signed-off-by: Aleksandar Stanoev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants